feat(Dropdown): add placement prop - Githubissues

mia-platform / design-system

React graphical components designed by Mia Platform

https://mia-platform.github.io/design-system/

Apache License 2.0

13 stars 1 forks source link

feat(Dropdown): add placement prop #707

Closed malta895 closed 1 week ago

malta895 commented 1 week ago

Description

Added Dropdown placement prop, which allows to set the placement of the dropdown relative to the parent

Dropdown

- added `placement` prop

[IMPORTANT] PR Checklist

[x] I am aware of standards and conventions adopted in this repository, defined in the CONTRIBUTING.md file

PR conventions

Please make sure your PR complies with the following rules before submitting it.

[x] PR title follows the <type>(<scope>): <subject> structure
[x] The PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).

NOTE
Some labels are used to generate release note entries: you can find the complete mapping between PR labels and release note categories here.
For a more detailed overview of PR labels, please refer to the dedicated CONTRIBUTING section.

Additional code checks

Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.

[ ] Changes are covered by tests
[x] Changes to components are accessible and documented in the Storybook
[x] Typings have been updated
[ ] New components are exported from the src/index.ts file
[ ] New files include the Apache 2.0 License disclaimer
[x] The browser console does not contain errors

malta895 commented 1 week ago

I'd improve the prop management

Aside for the typing, and the default value, is there something else you think should be improved in props management?