mia-platform / mlp

cli for easier deployment of Mia-Platform Console projects
https://docs.mia-platform.eu/docs/runtime_suite_tools/mlp/overview
Apache License 2.0
12 stars 2 forks source link

feat: increase api-server throttling options #1

Closed thobianchi closed 2 years ago

thobianchi commented 2 years ago

from some test on Kind: 23 resources: deployment, secret and cm

Same parameter as Kubectl:

restConfig.QPS = 50  
restConfig.Burst = 300

12.013s total

restConfig.QPS = 250  
restConfig.Burst = 800  

0.657s total

This parameters drastically increase apply performance reducing request throttling client-side. I think that is a good trade-off, we are not building a general purpose tool like Kubectl, mlp interact with kubernetes only for applying yaml file.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1 (a2059c2) into main (97469db) will decrease coverage by 0.33%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
- Coverage   68.35%   68.01%   -0.34%     
==========================================
  Files           9        9              
  Lines        1204     1210       +6     
==========================================
  Hits          823      823              
- Misses        304      310       +6     
  Partials       77       77              
Impacted Files Coverage Δ
pkg/deploy/deploy.go 66.03% <0.00%> (-0.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97469db...a2059c2. Read the comment docs.

davidebianchi commented 2 years ago

Why the changes in docker build workflow?

thobianchi commented 2 years ago

a mistake I worked on several features at the same time making a mess, updated with only the throttling options.