search

mia-workshop / MIA-Shared-Task-2022

An official repository for MIA 2022 (NAACL 2022 Workshop) Shared Task on Cross-lingual Open-Retrieval Question Answering.
MIT License
31 stars 4 forks source link

Baseline1 embedding links don't work #4

Closed snat1505027 closed 2 years ago

snat1505027 commented 2 years ago

Hi, thanks for the repo and the baseline models. I think there is an error with the baseline1's wiki embedding link. Using the script run_evaluation.sh, I am unable to download the embeddings.

# Line 9-12
for i in 0 1 2 3; 
do 
  wget https://nlp.cs.washington.edu/xorqa/cora/models/embeddings_baseline1/wiki_emb_en_$i 
done

Can you kindly modify the link? Thanks.

AkariAsai commented 2 years ago

Thank you so much for reporting this issue! That line should be

wget https://nlp.cs.washington.edu/xorqa/cora/models/embeddings_baseline1/wiki_emb_$i

I'll fix the script!

AkariAsai commented 2 years ago

@snat1505027 the script has been fixed! Thanks for reporting!

tommaso-green commented 2 years ago

I noticed that the links in the Readme in MIA-Shared-Task-2022/baseline/mDPR/ are still the old ones and need to be updated :)

snat1505027 commented 2 years ago

Thanks @AkariAsai for updating those links.

Also the download embedding links in the run_evaluation_cora.sh is not working as well. Can you kindly update them as well? Thanks.

AkariAsai commented 2 years ago

@tommaso-green Thank you for updating! I updated the README

AkariAsai commented 2 years ago

@snat1505027 Thank you for reporting! We fixed the issue as well. Please git pull and see if it works now.

AkariAsai commented 2 years ago

I'm closing this issue now, but please feel free to re-open if you find any remaining issues!