search

mia3 / crossmedia_fourallportal

0 stars 4 forks source link

[BUGFIX] tiny typo is fixed in a method which processing metadata fields #24

Closed rostyslavmatviiv closed 2 years ago

rostyslavmatviiv commented 2 years ago

This patch applies the following bugfix:

4allportaleabdullah commented 2 years ago

Hi @RostyslavMatviyiv, I would not recommend merging the first change you have mentioned, because the field name can also be changed in 4ALLPORTAL which will lead to the same problem.

The 'tiny fix' can be merged.

rostyslavmatviiv commented 2 years ago

@4allportaleabdullah Hi, okay but anyway issue still exists. It is bug, do you have an idea how it can be fixed? probably you know better how 4AP is working.

what can be used for physical filename identification? so it would be persist all the time?

4allportaleabdullah commented 2 years ago

Hi @RostyslavMatviyiv, this is normal behavior, where it's preferred to have more file copies when changing file names than replacing the existing file.

A unique identifier is the id field in 4ALLPORTAL.

rostyslavmatviiv commented 2 years ago

@4allportaleabdullah Okay, I understood you, then we need to care about existing usages of those files only. I mean if file has reference to another record and file is deleted and created again by the process we discuss here we should update reference record to keep connection between updated file and linked record. This is bug in my eyes. Would you like to see some hotfix here for this? or should I keep this logic on project side only?

rostyslavmatviiv commented 2 years ago

@4allportaleabdullah I have removed first bugfix from here. So you can merge this PR which contains only tiny fix for metadata mappings