search

miachm / SODS

A simple Java library for handle ODS (Open Document Spreadsheet, compatible with Excel and Libreoffice)
The Unlicense
74 stars 30 forks source link

Copyright Notice #10

Closed GreenFleece closed 4 years ago

GreenFleece commented 5 years ago

Could you include a copyright notice somewhere in your distribution? A copyright line in the README would suffice.

miachm commented 5 years ago

I am not familiar with that concept. What is a copyright notice?

GreenFleece commented 5 years ago

The copyright notice is a line of text to state who the owner of the copyright is. In other words, it's stating that the code belongs to you if any legal issues arise due to the copyright.

In it's simplest form, it's the following printed somewhere in your code: Copyright {yyyy} {name of copyright owner}

With the year replaced with the current year and the owner replaced with your name.

In order for the Apache License to apply, you need to include a copyright notice somewhere in your code. From the license text:

  "Work" shall mean the work of authorship, whether in Source or
  Object form, made available under the License, as indicated by a
  copyright notice that is included in or attached to the work
  (an example is provided in the Appendix below).
  ...
  Copyright {yyyy} {name of copyright owner}

The library is great and I would love to include it in a distributed product, but I can't get legal approval to use it unless you include the notice.

miachm commented 5 years ago

@GreenFleece i added a copyright notice at the README.MD.

lbyzx123 commented 4 years ago
com.github.miachm.sods SODS 1.1.1

when load 500 rows record: Caused by: java.lang.OutOfMemoryError: Java heap space at com.github.miachm.sods.Range.getValues(Range.java:226) at com.packagemanage.service.impl.ODSParserUtils.getHeaderFromSheet(ODSParserUtils.java:92)

miachm commented 4 years ago

@lbyzx123 Please open a new issue about that problem.

I need more info to recreate the problem in my computer.

Thanks