Linked values, line breaks issue and naming fixes

miachm / SODS

A simple Java library for handle ODS (Open Document Spreadsheet, compatible with Excel and Libreoffice)

The Unlicense

74 stars 30 forks source link

Linked values, line breaks issue and naming fixes #63

Open ideas-into-software opened 1 year ago

ideas-into-software commented 1 year ago

Added support for linked values, i.e. linking cell value to a sheet, file, URI or URL
Fixed bug with cell values which contain line separators - setting those via both office:string-value attribute and text:p element results in office:string-value taking precedence and text displayed containing no line breaks
Added BND instruction to include sources in OSGi jar
Fixed spelling mistake in OdsWriter naming
Bumped version to 1.5.3

miachm commented 1 year ago

Thanks!

I am confused with the 2 PR... So is this the right one?

ideas-into-software commented 1 year ago

Hi Miguel,

Yes, this (#63) is the PR I would ask you review and merge.

The other PR (https://github.com/miachm/SODS/pull/62) was closed in favor of this PR, which contains both (bug fixes as well as support for linked values).

Thanks!

I am confused with the 2 PR... So is this the right one?

juergen-albert commented 10 months ago

@miachm does anything speaks against merging the current state of this? We'd really like to use this and it would be great if we could just use a Version from maven Central instead of one from our own fork.

miachm commented 10 months ago

@juergen-albert I think I just forgot about it. Now it need to fix the conflicts t.t, but yes, it can be added to the next version.

juergen-albert commented 10 months ago

This is highly appreciated. If you need a hand, just reach out.