miahuynhh / footnote

A digital choreography notation tool.
0 stars 0 forks source link

Website not showing sign in errors on the webpage #34

Open kirupanandhini opened 4 days ago

kirupanandhini commented 4 days ago

When signing in with an incorrect username, password, or confirm password, the user should get an error that they do not meet the requirements. Ideally, this would be like an alert or some sort of message on the webpage. However, when a user creates an "incorrect account" the only get a console.log message, which they would only see if they opened up the console.

I would say that this bug is not super high priority because the database and backend handles incorrect users properly and the frontend shows the proper error message in the console. The error message just should also be displayed in a way that is accessible to all users.

In order to reproduce the bug, a user can "create" an account with an empty password field and the account will not be created. A string with the error message will be logged in the console (which can be accessed via the inspect element page).

I have determined that this issue can be fixed in the front end (by possible changing javascript to an alert() message). I will prioritize my other tasks but try to fix this in a timely manner.

miahuynhh commented 4 days ago

after beta release, i will modify the backend to return appropriate error codes along with the error/success messages

kirupanandhini commented 5 hours ago

Add error message instead of alert