Closed printscreen closed 7 years ago
@miaolz123 @nikolasp This is what I was thinking in my last comment.
@printscreen It look great !
Can I merge this PR into version 2.2.1 because this PR has a little break change ?
Oh, that makes sense since i did replace a property, thus changing the API to the component. Yeah, it should have a minor version bump. You are right. You want me to make that change?
@printscreen I just think it'll be better to add an example in ./example/simple/index.html
.
Ok, i will bump the version to 2.2.1 and update the ./example/simple/index.html
file
@printscreen yes, you can just change the version.
@printscreen and add you name at Contributions
in ./README.md
.
@miaolz123 Ok, updated
@printscreen This is great... Flexible and elegant solution.
Purpose of this PR is to add in the ability to define attributes you want on anchor tags. The problem I am trying to solve is
To use this new attribute, it might look something like this
Please comment with any suggestions or improvements you would like to see.