search

miasmos / op.gg-api

Serves op.gg web pages as json.
MIT License
81 stars 22 forks source link

Feature request - match_id and start_time/end_time for matches on summoner #2

Closed freakpants closed 9 years ago

freakpants commented 9 years ago

I'd love to see match_id and start/end of game for every game when pulling a summoner so that I can avoid entering the same game twice and sort them by when they happened :)

and thanks for fixing the bug :+1:

freakpants commented 9 years ago

Matchid as in the matchid for the game, not for spectating

miasmos commented 9 years ago

That information isn't available on the summoner page. You'll need to make multiple calls and combine the results.

freakpants commented 9 years ago

game-id

i should have referred to game_id, my bad. sadly its inside the class name, but its there.

freakpants commented 9 years ago

span class="_timeago tip" data-datetime="1436898547" data-type="" original-title="14. Jul. 20

span class="gameLength"> 24m 32s </span

these two spans contain the timestamp of the game, and the duration. not sure if its the beginning or end of the game, but one will of course imply the other :)

miasmos commented 9 years ago

Good catch. Added these.