search

miaulightouch / obs-virtual-cam

GNU General Public License v2.0
96 stars 14 forks source link

Add auto-start and start/stop following the built-in virtual camera #14

Closed rse closed 4 months ago

rse commented 4 months ago

For the virtual camera filters, add auto-start and start/stop following the built-in virtual camera

miaulightouch commented 4 months ago

I saw previous pr closed, is this pr ready for review?

rse commented 4 months ago

Yes, sorry for the confusion: I just moved the code to a branch on my side, so I had to open a new PR for the new branch. The autostart feature is ready for review by you. I'm using it actually in production of our company filmstudio since three weeks without problems, so it was even tested in practice.

miaulightouch commented 4 months ago

fix the formatting, then I think it's ready for merging.

rse commented 4 months ago

I've fixed the formatting in my touched files. Why you actions also complain about two files I've not even touched, I don't understand. But I've now also fixed the formatting there, too.

miaulightouch commented 4 months ago

I also double checked the previous CI log, before I left the comment. I don’t know how’s it failing the check between these builds.

rse commented 4 months ago

I've now tried to fix the formatting.