search

mib1185 / py-synologydsm-api

MIT License
16 stars 11 forks source link

Fix downloading shared photos from shared album #344

Closed alexismarquis closed 3 months ago

alexismarquis commented 4 months ago

Breaking Change This will extend the classes SynoPhotosAlbum and SynoPhotosItem by an editional property called passphrase which should set to None if the item or album is not shared by others or set to the corresponding passphrase when it is shared.

Context : Shared album have a passphrase field that is used in the public sharing link. It is also required by the download and thumbnail api methods. See https://github.com/home-assistant/core/issues/120817 for more detail.

This PR adds passphrase handling, fixing downloading photos from different users in shared albums. Additionally, it addresses a problem I encountered with HEIC photos that return an application/octet-stream content type.

Fixes #299

alexismarquis commented 3 months ago

@mib1185 could you take a look at this ?

alexismarquis commented 3 months ago

Hi, thanks for the feedback, requested changes has been done.

lodesmets commented 3 months ago

Hey, @alexismarquis, @mib1185

Looks good. I tested it, And it still seems to work. I also looked over the code, and it all seems great