search

mib1185 / py-synologydsm-api

MIT License
16 stars 11 forks source link

Guard expensive debug logging with isEnabledFor #358

Closed bdraco closed 1 month ago

bdraco commented 1 month ago

Note that update_query rebuilds the whole query string every time so it would be a bit cleaner to call it once, however its probably not worth optimizing if its only going to be called when debug is on now

mib1185 commented 1 month ago

the failing tests are not related - they are caused by yarl 1.9.5 (with 1.9.4 it was working), the url does not contain the https default port 443 anymore (expected https://nas.mywebsite.me:443 got https://nas.mywebsite.me) - but yes, adding the protocols default port is redundant and not needed - will fix this first

mib1185 commented 1 month ago

hi @bdraco , the tests are fixed now, please rebase your branch, thx :+1:

bdraco commented 1 month ago

Thanks @mib1185 Should be all set now