mib200 / vue-gtm

Simple implementation of Google Tag Manager in Vue.js 2.0
Apache License 2.0
242 stars 85 forks source link

Provide type definitions for TypeScript support #65

Closed Shinigami92 closed 4 years ago

Shinigami92 commented 5 years ago

close #61

mpoehler commented 4 years ago

I can confirm that this works.

mpoehler commented 4 years ago

@mib200 please take a look an merge ;-)

ascott18 commented 4 years ago

Would love to see this merged in. Is there anything outstanding that needs to be finished here?

clorichel commented 4 years ago

Totally legit, great work Shinigami92 ❤️

@mib200 would you consider merging this? Or do you prefer us to go for a @types/vue-gtm on https://github.com/DefinitelyTyped/DefinitelyTyped?

camilosampedro commented 4 years ago

This would surely be very helpful, and I would love to use it. ❤️

Are there any updates on this PR?

stipo42 commented 4 years ago

Please merge this in! Need ASAP