search

mib200 / vue-gtm

Simple implementation of Google Tag Manager in Vue.js 2.0
Apache License 2.0
242 stars 85 forks source link

Add query params to GTM script url #74

Closed babysharny closed 4 years ago

babysharny commented 4 years ago

Fixes #72

pibemillo commented 4 years ago

I am experiencing this same issue. Any idea when this will get merged in and be made available on npm?

acudworth commented 4 years ago

can we get this merged asap @mib200? This fixes key functionality, thanks

simplenotezy commented 4 years ago

@mib200 - merge please ;)

simplenotezy commented 4 years ago

I guess @mib200 could refuse to migrate this, as it has dependency on URLSearchParams which is not supported in IE.

simplenotezy commented 4 years ago

I tried getting your branch to work on my site, however, I couldn't. I ran yarn build (to get the dist file reflect your changes), but got:

ERROR in ./src/index.js
Module parse failed: /Users/constantsolutions/Projects/jwr-nuxt/node_modules/vue-gtm/src/index.js Unexpected token (13:15)
You may need an appropriate loader to handle this file type.
| const install = function (Vue, initConf = {}) {
|   // Apply default configuration
|   initConf = { ...pluginConfig, ...initConf }
|
|   pluginConfig.id = initConf.id
 @ multi ./src/index.js
mib200 commented 4 years ago

merged