mibe / FeedWriter

PHP Universal Feed Generator
http://ajaxray.com/blog/php-universal-feed-generator-supports-rss-10-rss-20-and-atom
GNU General Public License v3.0
191 stars 80 forks source link

Use tag instead of urn URI scheme for IDs #34

Open mibe opened 8 years ago

mibe commented 8 years ago

During researching for PR #33 I noticed that for ATOM IDs the code is using the urn URI scheme. This is not wrong per se, but IMHO the tag scheme is better. I've checked the ATOM feeds of some big sites, and all were using the tag scheme. It doesn't need a registration at IANA and also contains more information than a simple UUID.

Here are some opinions and information:

What do you guys think about that?

cukabeka commented 5 years ago

Highly appreciated. Actually, the urn:uuid is not always neccessary, as far as I researched now. Acutally, it seems to prevent RSS readers to read any further than one item in my setup. So the tag method seems to be a better way to go IMHO.

cukabeka commented 5 years ago

Weird, BTW: No matter what I pass on with $newItem->setId($url), all UUID for every Entry remain the same?! Is there any reason for that and how I could fix this?

mibe commented 5 years ago

Weird, BTW: No matter what I pass on with $newItem->setId($url), all UUID for every Entry remain the same?! Is there any reason for that and how I could fix this?

Can you open a new issue for that?