This allows a user to specify an option of what level of issue and above should fail the build

mibexsoftware / sonar-bitbucket-plugin

SonarQube plug-in to create pull request comments for found issues in Bitbucket Cloud

Other

122 stars 72 forks source link

This allows a user to specify an option of what level of issue and above should fail the build #54

Closed jgrodskiy-donlen closed 6 years ago

jgrodskiy-donlen commented 7 years ago

Issue #16

jgrodskiy-donlen commented 7 years ago

nfalco79 commented 6 years ago

Good PR even if I prefer a more significant name and in accordance with the other existing ones like BitbucketApproveMinSeverity (sonar.bitbucket.approvalMinSeverity).

mrueegg commented 6 years ago

@jgrodskiy-donlen Thanks for this pull request! I agree with the comments made by @nfalco79. As soon as the remaining naming/formatting issues are fixed, I'm happy to merge this. Thanks in advance

nfalco79 commented 6 years ago

also miss unit tests

mrueegg commented 6 years ago

Fixed and merged. Thanks for your contribution!