miblooming / JZ-TS24-2

Get it
https://cxdiy.taobao.com/
86 stars 35 forks source link

Auto-repeat time of touch events on the JZ-TS35 display #24

Open Pilson66 opened 4 years ago

Pilson66 commented 4 years ago

Hello. I am the owner of the JZ-TS display, with firmware 3.7.3, and when I click on any button on the interface, an almost instantaneous repeat of the touch events occurs. That is, for example, I press the button to extrude 10mm filament, and the display sends 2 (sometimes even 3) commands in a row, as a result, the printer extrudes into 10mm filament, and 20 or 30. The same thing happens when trying to calibrate the table. I click the "Next" button, and the printer performs in a row 2-3 actions of the printing movement at the indicated points. Therefore, we have to contrive that the touch time to the display is extremely short. Solution: set a delay between the first touch event and its auto-repeat, at least to 300 milliseconds.

miblooming commented 4 years ago

What's version of hardware on PCB? The touch delay is 100 milliseconds for "Click", and 200 milliseconds for "Long Press".

miblooming commented 4 years ago

There's a bug on button of extrude 10mm. It should not response on Long Press. The bug is fixed on V3.7.5. Here https://github.com/miblooming/JZ-TS24-2/tree/master/JZHelper_ui_editor/JZ-TS35WIFI___(3.5%264.0)/firmwave%20lastest_landscape

Pilson66 commented 4 years ago

JZ-TS35. Hardware version is 3.1 with wifi The same behavior not only on "extrude 10mm" button. It's on any other buttons.

miblooming commented 4 years ago

Do you connect the 2PIN power cable for screen? I test it on my screen, It's not that sensitive.

Pilson66 commented 4 years ago

Yes, power cable is connected.

miblooming commented 4 years ago

Maybe is a hardware issue! Something wrong with hardware of JZ-TS.

Pilson66 commented 4 years ago

@miblooming I believe that setting a delay of 500ms for "Long Press" will solve this problem. Can this be done?

miblooming commented 4 years ago

Current Setting: delay 100ms for click delay 300ms for page jump delay 200ms for long press It works fine in other hardware. Maybe there's a hard issue for your touch screen.

Pilson66 commented 4 years ago

Ok, if this is a hardware issue - how can I fix this? Or how do i get a replacement?

Pilson66 commented 4 years ago

Maybe still try to set 500ms for a long press?

miblooming commented 4 years ago

OK, I'll try to build a custom version for you.

---Original--- From: "Vadym Pylypenko"<notifications@github.com> Date: 2020/1/31 22:07:51 To: "miblooming/JZ-TS24-2"<JZ-TS24-2@noreply.github.com>; Cc: "Mention"<mention@noreply.github.com>;"Looming"<loomingxu@qq.com>; Subject: Re: [miblooming/JZ-TS24-2] Auto-repeat time of touch events on the JZ-TS35 display (#24)

Maybe still try to set 500ms for a long press?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

miblooming commented 4 years ago

https://drive.google.com/file/d/1KbbFM13ihGjHvvEDIF_gbUr1jAgWB6tE/view?usp=sharing Setting: delay 500ms for click delay 500ms for page jump delay 500ms for long press

Pilson66 commented 4 years ago

I tried your firmware with delay of 500ms, and the display began to work perfectly, without any false replay. Are you planning to add this fix to the general release? I would not like to ask you to do a personal version for me after each release. Thanks.

Pilson66 commented 4 years ago

With all 3 timeouts set, a new bug got out - a delay of 500ms for next click (not Long-Press) is also set. For example, I cannot quickly press 1 or more buttons in a menu, or in Gcode terminal. I think, the 500ms delay need only for the Long Press action. In other cases, the display works fine. Thanks.

miblooming commented 4 years ago

Setting: delay 100ms for click delay 300ms for page jump delay 500ms for long press replace "UPDATE2.BIN" in "UIEditor_landscape/sys/UPDATE2.BIN" And build a new firmware for touchscreen UPDATE2_2020-2-1.zip

Pilson66 commented 4 years ago

The new release is very strange. On some buttons, the Long-Press works as if it has a value of 100ms, while on the other buttont the Long-Press seems to be disabled at all, and the button only works after it is released. Please watch the video how it looks. If you need any additional tests - please write, I will do them. https://youtu.be/oHXlUqfWZCs

miblooming commented 4 years ago

Yes. Only some buttons react with Long Press

---Original--- From: "Vadym Pylypenko"<notifications@github.com> Date: 2020/2/1 18:40:34 To: "miblooming/JZ-TS24-2"<JZ-TS24-2@noreply.github.com>; Cc: "Mention"<mention@noreply.github.com>;"Looming"<loomingxu@qq.com>; Subject: Re: [miblooming/JZ-TS24-2] Auto-repeat time of touch events on the JZ-TS35 display (#24)

The new release is very strange. The Long Press works as if it has a value of 100ms on some buttons, while on the other Long Press it seems to be disabled at all, and the button only works after it is released. Please watch the video how it looks. If you need any additional tests - please write, I will do them. https://youtu.be/oHXlUqfWZCs

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Pilson66 commented 4 years ago

I do not understand. Why does half of the buttons in the Gcode menu react only when released, and the other half react as a constantly repeated press? Imagine that your keyboard on your PC or laptop behaves the same way - some buttons react only on release, while others are repeated few times instead of just one. This behavior is extremely illogical. But where a constant auto-repeat is completely unnecessary - it is present, and only interferes (for example, arrows to move and park the head, as well as the keyboard icon in the Gcode menu). Please fix this, as this interface behavior is very annoying. Thanks.

miblooming commented 4 years ago

Your hardware has some trouble.Touch panel too sensitive.  The firmware just for you.For other user, the default firmware works fine. Click Event take place on release.  Long Press Event is only used on Extrude page for E motor.  On other pages, Long Press does not take  effect except making a sound.

---Original--- From: "Vadym Pylypenko"<notifications@github.com> Date: 2020/2/1 21:06:22 To: "miblooming/JZ-TS24-2"<JZ-TS24-2@noreply.github.com>; Cc: "Mention"<mention@noreply.github.com>;"Looming"<loomingxu@qq.com>; Subject: Re: [miblooming/JZ-TS24-2] Auto-repeat time of touch events on the JZ-TS35 display (#24)

I do not understand. Why does half of the buttons in the Gcode menu react only when released, and the other half react as a constantly repeated press? Imagine that your keyboard on your PC or laptop behaves the same way - some buttons react only on release, while others are repeated few times instead of just one. This behavior is extremely illogical. But where a constant auto-repeat is completely unnecessary - it is present, and only interferes (for example, arrows to move and park the head, as well as the keyboard icon in the Gcode menu). Please fix this, as this interface behavior is very annoying. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

miblooming commented 4 years ago

In other words. Your touch panel has no Long Press Event because of hardware issue. Click Event tack place too frequently.

---Original--- From: "Vadym Pylypenko"<notifications@github.com> Date: 2020/2/1 21:06:22 To: "miblooming/JZ-TS24-2"<JZ-TS24-2@noreply.github.com>; Cc: "Mention"<mention@noreply.github.com>;"Looming"<loomingxu@qq.com>; Subject: Re: [miblooming/JZ-TS24-2] Auto-repeat time of touch events on the JZ-TS35 display (#24)

I do not understand. Why does half of the buttons in the Gcode menu react only when released, and the other half react as a constantly repeated press? Imagine that your keyboard on your PC or laptop behaves the same way - some buttons react only on release, while others are repeated few times instead of just one. This behavior is extremely illogical. But where a constant auto-repeat is completely unnecessary - it is present, and only interferes (for example, arrows to move and park the head, as well as the keyboard icon in the Gcode menu). Please fix this, as this interface behavior is very annoying. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Pilson66 commented 4 years ago

Ok, how can I get a replacement? I bought it on taobao in the official store, indicated on the github, paid about 30 usd for a full set for it, and about 10 usd for intermediary services + delivery from China to Ukraine, and as a result I can not use it normally ...

miblooming commented 4 years ago

There hardware issue maybe take place on the touch chip, or touch panel. So I'll send you a new touch chip, and touch panel, if you pay the delivery fee. Is it ok for you to replace the part by yourself? We did not go to work unit 2020-2-9, of later, because of plague in China.

Pilson66 commented 4 years ago

Ok, I have no choice anyway