search

mibrito707 / cordova-plugin-secure-storage-echo

Secure storage plugin for Apache Cordova
MIT License
73 stars 73 forks source link

Added Support for API 19 #17

Closed giordanocardillo closed 4 years ago

giordanocardillo commented 5 years ago

In the project I'm currently working on we need to keep compatibility from a minimum of Android 19.

I restored support making a RSA factory, to use legacy API only if needed.

I also had to change AES Cypher to GCM instead of CCM because I was having problems in Android 4.4.4 (Encryption was failing due to Cypher length).

ruchi-goyal commented 5 years ago

@mibrito707

We are using this plugin and it's working like charm on all devices except for Xiaomi Mi A1. On A1, SecureStorage.get is throwing “Keystore operation failed” error. Can you please look into this issue? Here is the list of devices I tested on: 1) Honor 7C Android 8 -> Working 2) Samsung A7 Android 9 -> Working 3) Samsung S8 Android 9 -> working 4) realme 3 pro android 9 -> Working 5) Xiaomi Mi A1 android 9 -> Not working 6) Android 10 -> Working 8) Xiomi note 5 pro android 9 - Working

gagan-chawla commented 5 years ago

@mibrito707 I'm facing the same issue with this specific phone

giordanocardillo commented 4 years ago

We are facing same issues on Xiaomi Mi A1. We don't have one to test, can someone help debugging?

mibrito707 commented 4 years ago

We are facing same issues on Xiaomi Mi A1. We don't have one to test, can someone help debugging?

Hey guys, thanks for reporting it. Can you please open a separate issue to keep track of this and see if someone can help with debugging since doesn't seem related to this PR.

giordanocardillo commented 4 years ago

We are facing same issues on Xiaomi Mi A1. We don't have one to test, can someone help debugging?

Hey guys, thanks for reporting it. Can you please open a separate issue to keep track of this and see if someone can help with debugging since doesn't seem related to this PR.

Someone with a Xiaomi Mi A1 just please open the issue and attach some logging. I'm facing only problems with customers I can't reach, they only talk to customer service. I need this fixed, we are using this in a financial application.

Also, @mibrito707 why isn't this merged? Is there any problem?

mibrito707 commented 4 years ago

Hey @giordanocardillo, thanks for this PR, I'm sorry that took that long to merge.