search

micado-eu / migrant_application

Application for the migrant
European Union Public License 1.2
1 stars 4 forks source link

Automatic Links: remove linebreaks #150

Closed balcse closed 3 years ago

balcse commented 3 years ago

Now if there is an automatic link in the glossary enty, a linebreak will be generated right after, even if it is in the middle of the sentence

balcse commented 3 years ago
linebreak_glossary
ivchicano commented 3 years ago

Can you copy here the text that has this problem? It will be helpful for debugging the issue

balcse commented 3 years ago

this is how it looks like in the PA-app:

anderes Wort für >**Bundesagentur für Arbeit

**

Die Arbeitsagentur

(früher: Arbeitsamt) ist Ansprechpartnerin für Bürgerinnen und Bürger und Unternehmen für Themen des **Arbeits- und Ausbildung

smarktes**.

Wichtigeste Aufgaben der Agentur für Arbeit sind:

Menschen ohne Arbeit beantragen zusätzlich bei der Arbeitsagentur

ihr Arbeitslosengeld. Auch >**Aktivierungsgutschein

e** vergibt die Arbeitsgentur.

Dies ist die [Homepage](arbeitsagentur

.de/en/welcome>) der Agentur für Arbeit in Hamburg.

balcse commented 3 years ago

and here ist the link to the migrant app entry: https://migrants.micadohh.online/glossary?id=127

trtstm commented 3 years ago

We are also having similar problems.

@balcse do you have problems with bold text not being bold anymore and empty lines disapearing?

balcse commented 3 years ago

Yes, sometimes instead of bold texts we get some with an asterisk, like above (like **Bundesagentur für Arbeit**in the example above)

balcse commented 3 years ago

A comment by Mert on when it appears: "When I edit an entry and if this entry has existing bold phrases, they are marked with asterisk in the new edited version. If I delete whole text and rewrite it assigning words bold again. Then, it worked in most cases"

ivchicano commented 3 years ago

All the issues mentioned should be fixed now, please reopen this issue or open another one if you find more bugs with the editor

trtstm commented 3 years ago

Is this fixed in just the migrant app or also the PA?

ivchicano commented 3 years ago

It should be fixed in all apps. The problem was when saving the content in the PA or CSO apps (if curious, the HTML to Markdown conversion was adding a line break after tags, which are used by the references), so the content previously saved before this patch will still look broken, but rewriting the content now should work correctly.