micado-eu / pa_application

application for the PA
European Union Public License 1.2
1 stars 4 forks source link

Guided Processes - Check the "Add Process Form" & "Edit Process Form" #87

Closed Leo-Moertenhuber closed 3 years ago

Leo-Moertenhuber commented 4 years ago

Hi @GiuseppeCSI - below is a list of my proposed updates

updates for "Add Process Form":

updates for the "Edit Process Form":

https://www.figma.com/file/i2iikyHbwCfngbNETXqHPK/MICADO-Migrant-APP---look-%26-feel?node-id=78%3A20

if anything is unclear let me know

Leo-Moertenhuber commented 4 years ago

Hi Giuseppe, just a small update / probably a correction.

I think I was maybe to quick to update the figma file regarding the seperated image upload button - I initially thought the images will be separated from the text but as I understand it now this isn´t the case, and the images will be included in the text. Ivan left me a comment since I proposed the same idea for the information centre.

basically don´t hurry with the implementation as I think it´s likely that we keep the image upload button with the text formatting options. I will leave another comment when we have a final decision.

Sorry for the back on forth with the feedback

gi-dorio commented 3 years ago

I implemented most of the minor changes, except for two:

  1. number of possible characters on top: the characters counter is built-in in the input quasar component and it seems that its position cannot be decided. I will look more into it, but if not possible i wouldn't suggest adding new code to create a separate counter only to put it on top; 2.Text Formatting options moved below the input field (description): this requires a little change in the glossary editor component, so i would ask @ivchicano for help on this.
ivchicano commented 3 years ago

I will move the menu bar for options below the input field while fixing #88

ivchicano commented 3 years ago

I have moved the bar to the bottom side of the editor. Also I added a slot option to add the translate state button to the right. You can find it used in the EditElement component like in the following snippet:

<glossary-editor
  class="desc-editor q-mb-xl"
  data-cy="description_input"
  v-model="internalDescription"
  :maxCharLimit="description_max_length"
  ref="editor"
>
  <translate-state-button
    v-model="selectedTranslationState"
    :isForDefaultLanguage="langTab===$defaultLang"
    :objectId="elemId"
    :readonly="!(langTab===$defaultLang)"
    @micado-change="(a) => {selectedTranslationState = a.state}"
    class="q-my-sm"
  />
</glossary-editor>
gioppoluca commented 3 years ago

I have moved the bar to the bottom side of the editor. Also I added a slot option to add the translate state button to the right. You can find it used in the EditElement component like in the following snippet:

<glossary-editor
  class="desc-editor q-mb-xl"
  data-cy="description_input"
  v-model="internalDescription"
  :maxCharLimit="description_max_length"
  ref="editor"
>
  <translate-state-button
    v-model="selectedTranslationState"
    :isForDefaultLanguage="langTab===$defaultLang"
    :objectId="elemId"
    :readonly="!(langTab===$defaultLang)"
    @micado-change="(a) => {selectedTranslationState = a.state}"
    class="q-my-sm"
  />
</glossary-editor>

Mind that the translation state button is a single instance for the whole form so the slot che be good if only a the glossary is present but if there is more than one field the translationstate button has to be placed in the tabbed card. Also the tabbed card MUST contain only the translated content and NOT other fields like numeric one that are not part of the translation tables

gioppoluca commented 3 years ago

I implemented most of the minor changes, except for two:

  1. number of possible characters on top: the characters counter is built-in in the input quasar component and it seems that its position cannot be decided. I will look more into it, but if not possible i wouldn't suggest adding new code to create a separate counter only to put it on top; 2.Text Formatting options moved below the input field (description): this requires a little change in the glossary editor component, so i would ask @ivchicano for help on this.

@Leo-Moertenhuber and @GiuseppeCSI please remember that when we have a QUASAR field that offer a feature we MUST adapt our design to be able to use that feature and we WILL NEVER change the provided functionality for a custom hack. In these cases design MUST find a compromise to ease development work. Plese apply this approach to all similar cases.

Leo-Moertenhuber commented 3 years ago

Alright - I am sorry if I proposed some custom changes. In this case please always tell me if future suggestions are not possible within the Quasar framework (sadly I have no real experience working with quasar so it's sometimes difficult for me to know which designs are going too far)

Leo-Moertenhuber commented 3 years ago

I think this should be my last update/ feedback for the guided processes forms:

attaching this screenshot for an easier understanding Guided-Processes-final-feedback

ivchicano commented 3 years ago

I have moved the bar to the bottom side of the editor. Also I added a slot option to add the translate state button to the right. You can find it used in the EditElement component like in the following snippet:

<glossary-editor
  class="desc-editor q-mb-xl"
  data-cy="description_input"
  v-model="internalDescription"
  :maxCharLimit="description_max_length"
  ref="editor"
>
  <translate-state-button
    v-model="selectedTranslationState"
    :isForDefaultLanguage="langTab===$defaultLang"
    :objectId="elemId"
    :readonly="!(langTab===$defaultLang)"
    @micado-change="(a) => {selectedTranslationState = a.state}"
    class="q-my-sm"
  />
</glossary-editor>

Mind that the translation state button is a single instance for the whole form so the slot che be good if only a the glossary is present but if there is more than one field the translationstate button has to be placed in the tabbed card. Also the tabbed card MUST contain only the translated content and NOT other fields like numeric one that are not part of the translation tables

Then what do you think of separating the editor from the styles menu into different components so that you can use inline styling or flex with the translation state button?

gi-dorio commented 3 years ago

Except for the translation button issue, the rest is done. We could close this if we decide to leave the translation button as it is.