Closed jgiunta1 closed 4 years ago
After setting "type" to tropical I'm actually getting Aries which makes more sense
After setting "type" to tropical I'm actually getting Aries which makes more sense
Okay. @jgiunta1 Thanks for taking the time to try out the library. Feel free to contribute (new features) as you see fit.
Hey this API is awesome, I think you all did some great work! I just wanted to point out a small issue with the Pisces dates.
Summary
4/20 is registered as Pisces when it should be Taurus. The pisces date range is incorrect compared to the reference docs linked here: https://www.npmjs.com/package/sign-teller/v/3.1.2
See: https://www.horoscope.com/zodiac-signs for correct date ranges
Steps to reproduce
Run the following with Jest
signHelper.js
signHelper.test.js
Output