search

micahcowan / bobbin

A terminal-driven Apple II-series emulator aimed at efficient development for 8-bit Apple computers
MIT License
26 stars 3 forks source link

Fixes build problem using gcc 13 (debian) #1

Closed buserror closed 1 year ago

buserror commented 1 year ago

This is a minor change to fix a warning (and therefore an error with -Werror on recent gcc. Basically the dumb warning disappears if you at least 'test' the result of snprintf()

micahcowan commented 1 year ago

I appreciate you bringing my attention to this! As mentioned in a chat on the AppleFritter Discord, I went another way and just removed the -Werror (commit aa4c52a9, now present in bobbin 0.4.1), which I really oughtn't have left in for production (pre)releases. I now specify CFLAGS=-Werror in my ./configure invocation, instead.

I've now added commit acdfb9b6, which should additionally shut up the warning message for that (untested). I'd rather do that then write the code in a slightly silly way, that I then feel compelled to explain to the reader.

Thanks again, and hope you find this project helpful!