search

micahgodbolt / grunt-phantomcss

Other
24 stars 14 forks source link

Adding phantomjsArgs array to options #11

Closed tiagoroldao closed 8 years ago

tiagoroldao commented 8 years ago

The current setup does not allow passing arguments to phantomJS, which is required to run against websites which block SSLv3 connections (PhantomJS defaults to SSLv3).

This can now be achieved by through a phantomjsArgs option in the Gruntfile. The common issue of needing to run against something other than SSLv3 becomes just this:

phantomcss: {
    options: {
        [...]
        logLevel: 'warning', // [debug, info, warning, error]
        phantomjsArgs: [
            '--ssl-protocol=tlsv1',
            '--ignore-ssl-errors=true',
        ]
    }
}
linavegiene commented 8 years ago

@micahgodbolt, please can you review this and merge? I tested it and this solves https issue.

micahgodbolt commented 8 years ago

Certainly. I can see how essential this could be.

Do we know if this works the same way for PhantomJS 2.1?

tiagoroldao commented 8 years ago

No reason not to, there were no changes to how the CLI works (and this presumes no arguments in particular)

Also tested rebasing with your branch 1.0.0, and it works as expected.

micahgodbolt commented 8 years ago

Perfect, thanks.

On Tue, Mar 8, 2016, 2:44 AM tiagoroldao notifications@github.com wrote:

No reason not to, there were no changes to how the CLI works (and this presumes no arguments in particular)

Also tested rebasing with your branch 1.0.0, and it works as expected.

— Reply to this email directly or view it on GitHub https://github.com/micahgodbolt/grunt-phantomcss/pull/11#issuecomment-193719729 .

micahgodbolt commented 8 years ago

I made a few minor changes to this over in #14. Wish I could merge them into here, but can't. So i'm going to close this and merge in #14.