search

micahhausler / k8s-oidc-helper

Helper tool for authenticating to Kubernetes using Google's OpenID Connect
MIT License
201 stars 86 forks source link

Updated the Dockerfile and modified the output. #5

Closed ChienHuey closed 7 years ago

ChienHuey commented 7 years ago

Updated the Dockerfile to where the binary is built as part of the image instead of just being copied into the container.

Modified the output to generate the kubectl config command such that it lets kubectl handle updating the .kube/config rather than requiring the user to copy and paste user tokens into .kube/config. Should minimize the chances of user messing up their .kube/config.

StevenACoffman commented 7 years ago

@ChienHuey When I do: go get github.com/xogroup/k8s-oidc-helper I get:

../../../work/src/github.com/xogroup/k8s-oidc-helper/main.go:231:32: response declared and not used
StevenACoffman commented 7 years ago

@ChienHuey Your changes allow me to install it and run successfully, but the output of this line displays as a series of integers:

[%!
(uint8= 117) %!
...
(uint8= 10)]
ChienHuey commented 7 years ago

Cleaned up the code to remove the yaml library and the response that was declared but that I'm not using. The image is smaller at 280mb vs over 700mb.

micahhausler commented 7 years ago

Hi all, I've been on vacation the last 2 weeks, and should be able to respond more this coming weekend.

micahhausler commented 7 years ago

Thanks for the PR, closing in favor of #8