search

micahjsmith / FredData.jl

Pull data from Federal Reserve Economic Data (FRED) directly into Julia
https://micahjsmith.github.io/FredData.jl/dev
Other
64 stars 19 forks source link

Outdated compatibility with DataFrames at General Registry #18

Closed FuZhiyu closed 3 years ago

FuZhiyu commented 3 years ago

Hi,

The entry of this package on general registry is outdated. It doesn't allow for the latest DataFrames.jl@0.22.

I'm not familiar with the registry mechanism, but it seems the issue is caused by the compat rule in this form

PackageD = ">=0.4, <1"

which does not meet the criteria for automatic merging. Could you update the registry info? Many thanks for this handy package!

micahjsmith commented 3 years ago

Hi @FuZhiyu I am taking a look at this, thanks for reporting

chenwilliam77 commented 3 years ago

Hi Micah,

Flagging this problem again. Would it be possible to just release v0.5 with an updated restriction on DataFrames? I've dev'd FredData and had no issue running tests locally with DataFrames at v1.0.0. It'd be super helpful if newer versions of DataFrames could be permitted, as they've reached v1.0 now.

Best,

William

micahjsmith commented 3 years ago

@micahjsmith @FuZhiyu For sure, didn't get around to fixing last time but will look this weekend. If you are able, you are welcome to submit a PR that would fix the issue and I can cut a new release

micahjsmith commented 3 years ago

Bumped in #19

micahjsmith commented 3 years ago

Closed by https://github.com/JuliaRegistries/General/pull/35151