search

micahke / obsidian-gpt3-notes

An Obsidian plugin to generate notes based on GP3 output.
MIT License
170 stars 15 forks source link

Add setting for custom API URL #20

Closed Pukimaa closed 1 year ago

Pukimaa commented 1 year ago

Fixes #17

  1. Haven't tested it much (@Jackiexiao can you test it fully please?)
    • I only tested that it sends the right request. Sadly my used API is down so I couldn't get an actual response but the headers and everything seemed fine.
  2. You might want to bump the version, build it and release it :)
  3. You could store the default API in a variable but I was way too lazy and it shouldn't change too much + there is search and replace
  4. Feel free to change the description of the setting.
    • Maybe say you shouldn't touch it if you don't know what you're doing
    • Or use something different altogether
Jackiexiao commented 1 year ago

Sorry, I don't use this plugin anymore and don't have a custom api too, but thx for your PR!

Pukimaa commented 1 year ago

Ok my API is back online and I tested it and had no issues whatsoever. @micahke ready to merge!