micahosborne / uFrame

85 stars 21 forks source link

Code Handlers are listed as obsolete but no documented other approach? #6

Open grofit opened 8 years ago

grofit commented 8 years ago

So historically you either used the action designer (default) or you specified your handler was a Code Handler and just wrote the logic for the handler yourself.

In this version it seems to list Code Handlers as obsolete, however I can find no documentation around what is the new preferred approach for this?

jjjuande commented 8 years ago

Just override the handler method on the system. There should be a .cs file defining a partial class (for each system) in the system folder for the code created.

grofit commented 8 years ago

Ok, this still seems a bit nasty compared to the old code handlers, I could be wrong as I only used it briefly but I think they used to be their own files and included via composition into the systems, which seemed far nicer so you could see all the handlers (granted this would mean a file per handler but they are far easier to maintain and explore as multiple files vs one big system.

Assuming it used to create a separate file is there any benefit to not creating code based handlers as isolated classes and using composition to include them at the system level? (I know I could do this manually but then I would have to infer my own pattern for each handler which could be completely different to someone elses so its not as consistent as it could be).

jjjuande commented 8 years ago

The file is a partial class. You can have every handler on its own file. Whatever you like the most.

grofit commented 8 years ago

yeah my point is its a bit of digging and a lot of the codegen files live in the same place, also the designer based handlers have their own files, I would personally prefer for consistency to have code handlers in their own files too, but at least I know the current official approach.