micahpearlman / MonkSVG

SVG parsing framework in C++
BSD 3-Clause "New" or "Revised" License
79 stars 19 forks source link

stroke-linejoin is almost unimplemented #14

Open gerchicov opened 11 years ago

gerchicov commented 11 years ago

Your line joins look like you use "bevel" style. But If I perform something like this:

onPathBegin onPathMoveTo onPathLineTo //multiple times to draw a rect onPathClose onPathEnd

After this code a rect should be drawn. But I see the first and the last line haven't a join at all even if these points are the same. You haven't implemented stroke, but I think at least one join style should be fully workable

gerchicov commented 11 years ago

here is an example picture: загрузить фото,загрузить картинку

micahpearlman commented 11 years ago

The stroking implementation is quite naive and really needs to be re-implemented.

gerchicov commented 11 years ago

As a temporary solution I suggest to add drawing of the first line (between 2 first points) in onPathClose(). But how to correctly obtain the first 2 points in this function?