search

micahpearlman / MonkVG

MonkVG is an OpenVG 1.1 like vector graphics API implementation optimized for game use currently using an OpenGL ES backend that should be compatible with any HW that supports OpenGL ES 2.0 which includes most iOS and Android devices.
Other
376 stars 66 forks source link

Updated iOS static library build settings #9

Closed lukelutman closed 12 years ago

lukelutman commented 12 years ago

Changed the 'Public Headers Folder Path' and changed the visibility of the headers so that xcode puts the public headers where other projects in the workspace can find them (other projects in the workspace no longer have to explicity add MonkVG to 'Header Search Paths').

See: http://www.blog.montgomerie.net/easy-xcode-static-library-subprojects-and-submodules

lukelutman commented 12 years ago

With this change the headers get copied into $(TARGET_BUILD_DIR)/include/VG when the project is built. Ideally, this would be $(TARGET_BUILD_DIR)/include/MonkVG, but that breaks when you include those headers in another project because the headers themselves use <vg/file.h>.

Would you be open to renaming the include/VG folder to include/MonkVG (all the include statements would also have to be updated to <MonkVG/file.h>)? It's a little more clear and consistent, especially from the point of view of another project that wants to use those headers.

I'm happy to make the changes and update MonkSVG to match :-)

micahpearlman commented 12 years ago

Cool thanks. Hmmm... in regards to the "MonkVG" vs. "VG" include path, my hopes, dreams, and aspirations where that MonkVG could be used interchangeably with another OpenVG implementation. I understand the want to be consistent with how Apple names there libraries and header paths. Hmmm... a little resistant but don't think it would be that big of a deal...

lukelutman commented 12 years ago

That's a good point. It would still be api compatible though. Someone wanting to switch implementations would just have to change some include statements, which should just be a simple search/replace job :-)

micahpearlman commented 12 years ago

Personally I would prefer to keep it as is but I can acquiesce on this without much looking back -- so if you send me a pull request I'll accepts it.

lukelutman commented 12 years ago

Thanks Micah. Pull request submitted :-)