micahstairs / bga-innovation

MIT License
6 stars 2 forks source link

Jet, Karaoke, Charitable Trust, and Stethoscope need to be tested with endorse feature #632

Closed ultimatefiend closed 1 year ago

ultimatefiend commented 1 year ago

The main dogma effect is reliant upon the results of the card's echo effect so the endorse feature will need to be specially handled by these cards.

ultimatefiend commented 1 year ago

add Dentures to the list.

Watno said that the main effect should offer a choice for some of these effects (e.g. Karaoke) when the endorse is used.

micahstairs commented 1 year ago

I did a full audit of cards we should check:

We should also make sure these cards behave correctly when the card has been executed twice in the current nesting stack (e.g. Democracy is not behaving correctly in this regard).

micahstairs commented 1 year ago

I found a few relevant BGG threads:

madisonsilver commented 1 year ago

Endorsing Charitable Trust gives the following error on the second iteration of the echo effect:

Unexpected error: Error while processing SQL request (Localhost via UNIX socket): INSERT INTO indexed_auxiliary_value (nesting_index, index_id, value) VALUES (0, 2365493, 42) Duplicate entry '0-2365493' for key 'PRIMARY' (reference: GS1 03/01 00:31:33)

This makes it impossible to proceed with the game (see e.g https://studio.boardgamearena.com/table?table=439017 )

ultimatefiend commented 1 year ago

Karaoke just triggers the second card that is melded. It doesn't execute the first card that was melded.

You have to execute the 2nd non-demand effect. Execution of 8 Rocketry is complete. No card matches the criteria of the effect. You have 7 . You have to execute the non-demand effect. You execute the non-demand effect(s) of 8 Rocketry. You have to execute the 1st non-demand effect again because it was endorsed. Execution of 8 Rocketry is complete. No card matches the criteria of the effect. You have 7 . You have to execute the non-demand effect. You execute the non-demand effect(s) of 8 Rocketry. You have to execute the 1st non-demand effect. You draw and meld 8 Rocketry. You choose the value 8. You have to execute the echo effect again because it was endorsed. You draw and meld 9 Fission. You choose the value 9. You have to execute the echo effect. You have 3 . kahliadev1 has 0 . You endorse the dogma of 9 Karaoke with as the featured icon. You tuck 1 Masonry from your hand.

In this case, the non-demand effect of Fission should have been executed first.

micahstairs commented 1 year ago

I left some questions on https://boardgamegeek.com/thread/1093137/endorsing-democracy to get clarity on how to handle Democracy.

micahstairs commented 1 year ago

With Karaoke, it's possible that when it comes time to execute the 2nd melded card, it may not be a top card or even on the board anymore. For this reason, we will need to get the player to click on buttons to choose the card (instead of the card itself). These buttons will only appear when Karaoke was endorsed though.

ultimatefiend commented 1 year ago

Dentures and Morphine check out.