search

micahstairs / bga-innovation

MIT License
6 stars 2 forks source link

Extreme Pride and Prejudice Setup Causes Numerous Bugs #664

Open madisonsilver opened 2 years ago

madisonsilver commented 2 years ago

Reproduction steps:

  1. Play with Echoes and Artifacts.
  2. Draw a hand with no Echoes cards and at least one non-Echoes card.
  3. Do the infinite Pride and Prejudice combo (i.e activate pride and prejudice with all piles equal size).

Results: Many bugs including, but not limited to:

Examples: https://studio.boardgamearena.com/gamereview?table=414715 https://studio.boardgamearena.com/gamereview?table=418715

ultimatefiend commented 2 years ago

might want to do a mass transfer in this case...sorta like fission

micahstairs commented 2 years ago

This is a known existing issue (we didn't have a GitHub issue for it though, I don't think).

A bulk transfer is not a bad idea, but it would be nice to trim down the notification sizes so that this doesn't happen in the first place.

micahstairs commented 2 years ago

https://boardgamearena.com/bug?id=68466 is also related, but in that case we can't do a bulk transfer. So this suggests that fixing the underlying problem is the best way to proceed.

This is relatively low priority though, since it's an existing issue and Echoes doesn't make it any worse.

ultimatefiend commented 2 years ago

Could we transfer cards directly to the score pile? e.g. peek at the card at the top of the next draw pile, then see if that matches a color with the minimum number of visible cards...if so score it. If not, meld it and stop. That would reduce the number of log messages.

micahstairs commented 2 years ago

That would cut the number of messages in half, which would help.

But I think the bigger problem is that each card transfer sends a ton of metadata to the frontend (and that's the best place to cut down the size).

madisonsilver commented 2 years ago

This is relatively low priority though, since it's an existing issue and Echoes doesn't make it any worse.

I could be wrong, but I think that Echoes does make it worse since there are more cards that can be transferred (and thus the bug is more likely to occur).

ultimatefiend commented 1 year ago

I had a game where 366 points were scored (but not echoes cards) and the error did not occur.