micahstairs / bga-innovation

MIT License
6 stars 2 forks source link

Adjust existing base cards to handle 4th edition variants #971

Closed micahstairs closed 1 year ago

micahstairs commented 1 year ago
micahstairs commented 1 year ago

In the materials file, let's denote 4th edition specific wording using the _fourth suffix (e.g. non_demand_effect_1_fourth).

ultimatefiend commented 1 year ago

shouldn't the existing text be changed to "third" edition?

micahstairs commented 1 year ago

That's going to be a much more intrusive change (a lot more lines would be touched).

ultimatefiend commented 1 year ago

isn't it the same number? We'd only add it to the ones that are different?

micahstairs commented 1 year ago

Ah true! Let's go with your proposal then.

micahstairs commented 1 year ago

Actually, using "third" will be more confusing, since we haven't retired the 1st edition yet, so most of the time we'd be using the "third" edition text for first edition too. I'll stick with "fourth" and we could always revisit this later.

ultimatefiend commented 1 year ago

classification is already doing everything the card says so nothing needs to happen.