micahstubbs / drift

an ES2015 port of h2o-flow
MIT License
1 stars 2 forks source link

plot button does not render plot #102

Open micahstubbs opened 7 years ago

micahstubbs commented 7 years ago
screen shot 2017-01-18 at 7 30 20 pm
micahstubbs commented 7 years ago

it should look like this

screen shot 2017-01-18 at 7 31 55 pm
micahstubbs commented 7 years ago

broken at a020787d0b97d8250d1040636156a2a0d077d451 on 1/18

micahstubbs commented 7 years ago

broken at b6f713951a817d4a57e94016389250163734aa0c at end of day on 1/17

micahstubbs commented 7 years ago

broken at ae48d836dee0f5e43e13cff5106bed50fdcbe3a6 on end of day 1/13

micahstubbs commented 7 years ago

broken at fb89922543d55e08e6e18ed177e200e1ea91448c on end of day 1/5

micahstubbs commented 7 years ago

bug state at fe79a5b12b18346f7ee4354cb95eea7e0c233ba1 on end of day 12/22, cannot test

screen_shot_2017-01-18_at_7_41_15_pm
micahstubbs commented 7 years ago

bug state at 4188e080a06d6e0d3660eeb8babf36f1a51f3ba4 on 12/19

micahstubbs commented 7 years ago

working at 2d6b9dfe4147c94aaaa787334461945288611bba on 12/12

micahstubbs commented 7 years ago

working at c133607d10d4dd5d8fc99b5ef88dc106d3c0b38f at end of day on 12/14

micahstubbs commented 7 years ago

working at 08c8710886988453ceedc0521df9691b0cbcb150 at end of day 12/15

micahstubbs commented 7 years ago

working at 94553527652ac88a58d1e352fc772290cb55c6ba at end of day on 12/16

micahstubbs commented 7 years ago

broken at 5e51770a87be23e084c8906bed11872d8a2d89e9 at end of day 12/27

micahstubbs commented 7 years ago

bug state at 1638ba8028ac72ea6179b79e3bd0580165c4732f on 12/27

micahstubbs commented 7 years ago

different bug state at 1ec9634ab8a271aeeaac54f1be96833bc828b320 on 12/19

screen shot 2017-01-18 at 7 57 04 pm
micahstubbs commented 7 years ago

so sometime after end of day 12/16 and before end of day 12/27

micahstubbs commented 7 years ago

broken at fd3f6edacc9549c6fd964d54efe631c3e1c81780 at end of day 12/19

can test by pasting this command

plot inspect 'characteristics', getColumnSummary "arrhythmia.hex", "C4"
micahstubbs commented 7 years ago

broken at e30cb6c457e81dba79d08aedc21aeefeec4080be at end of day on 12/20

micahstubbs commented 7 years ago

working at 1dc853ffcd8684691aa111108cf1df48071717f0 on 12/19

micahstubbs commented 7 years ago

working at 1ec9634ab8a271aeeaac54f1be96833bc828b320 on 12/19

micahstubbs commented 7 years ago

working at 9797aa5ea8739e7a84724edcdf2bf9bcc6368988 on 12/19

micahstubbs commented 7 years ago

broken at 4188e080a06d6e0d3660eeb8babf36f1a51f3ba4 on 12/19

micahstubbs commented 7 years ago

broken at a48ee6daabdaf8fc9f7630570d88ff5ce3295531 on 12/19

micahstubbs commented 7 years ago

broken at 5aab666b1002c9c039c0db7ae4e4098611e1f0ce on 12/19

micahstubbs commented 7 years ago

broken at 06a3db6f3a34d585b704d44a71ac707003c4cb96 on 12/19

micahstubbs commented 7 years ago

broken at fb622ac5594abee10dbedecb6712edc61592781a on 12/19

micahstubbs commented 7 years ago

broken at de24421ef0612b8bb1bf6889634799fc985c87a1 on 12/19

micahstubbs commented 7 years ago

working at 648dc3755b7b16539d8b0b2213a01b06d5163a3b on 12/19

micahstubbs commented 7 years ago

ok, 🔎 found it! de24421 on 12/19 is the commit that breaks the plot button

micahstubbs commented 7 years ago

fixed by passing the _ to plot in routines