micander / atrias

Automatically exported from code.google.com/p/atrias
0 stars 0 forks source link

Rename RtOpsCommand and RtOpsCommand_t to RtOpsState #97

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The type controllerManager::RtOpsCommand is no longer just a command -- it as a 
state in RT Ops's state machine. Therefore, it should be renamed to RtOpsState. 
RtOpsCommand_t should be updated as well.

Note: This should be fixed in robot_state.msg too (there's a comment with this 
type's name in it).

Michael, I'm assigning this to you. It affects both our code, but you have the 
nice refactoring software ;)

Original issue reported on code.google.com by jrvanwhy on 31 Aug 2012 at 10:05

GoogleCodeExporter commented 9 years ago
We've decided to put all RT Ops-related enums into the atrias::rtOps namespace. 
This should also apply to RtOpsEvent.

I am currently creating some new enums that are already in this namespace.

Original comment by jrvanwhy on 31 Aug 2012 at 10:25

GoogleCodeExporter commented 9 years ago
On another note, that variable in robot_state should be renamed to rtOpsState 
(or something like that). It reflects RT Ops's state, not the Controller 
Manager's state.

Original comment by jrvanwhy on 3 Sep 2012 at 7:48

GoogleCodeExporter commented 9 years ago
This is a simple, non-important refactoring change of low priority.

Original comment by jrvanwhy on 7 Sep 2012 at 3:41

GoogleCodeExporter commented 9 years ago

Original comment by jrvanwhy on 13 Dec 2012 at 1:05

GoogleCodeExporter commented 9 years ago
This issue was closed by revision cc1557fd0093.

Original comment by jrvanwhy on 13 Dec 2012 at 1:25