"Invalid DNS entry" error when changing any information on network page

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Select 'Network' tag
2. Change any value
3. "Error in DNS Address: Invalid value" pops up

What is the expected output? What do you see instead?
DNS entry should only be checked if there is a non-blank entry in DNS add
option

What version of the product are you using? On what operating system and web
browser?
r4654

Please provide any additional info below.

File /www/cgi-bin/webif/network.sh line 240
Noticed an extra field in the validate check for DNS entry

ip|FORM_dnsadd|@TR<<DNS Address>>|required||$FORM_dnsadd

Either remove "required|" entry field or remove empty "||" after "required|"

Original issue reported on code.google.com by alisonken1 on 13 Jan 2009 at 7:10

[GoogleCodeExporter]

Index: www/cgi-bin/webif/network.sh
===================================================================
--- www/cgi-bin/webif/network.sh        (revision 4654)
+++ www/cgi-bin/webif/network.sh        (working copy)
@@ -237,7 +237,7 @@
 netmask|FORM_${interface}_netmask|$interface @TR<<WAN Netmask>>||$FORM_netmask
 ip|FORM_${interface}_gateway|$interface @TR<<Default Gateway>>||$FORM_gateway
 ip|FORM_${interface}_pptp_server|$interface @TR<<PPTP Server IP>>||$FORM_pptp_server
-ip|FORM_dnsadd|@TR<<DNS Address>>|required||$FORM_dnsadd
+ip|FORM_dnsadd|@TR<<DNS Address>>||$FORM_dnsadd
 EOF
                equal "$?" 0 && {
                        uci_set "network" "$interface" "proto" "$FORM_proto"

Original comment by alisonken1 on 13 Jan 2009 at 7:17

[GoogleCodeExporter]

Thanks, fixed in r4657.

Original comment by kemen04@gmail.com on 15 Jan 2009 at 3:06

• Changed state: Fixed