micc83 / Nuwk

Nuwk! makes it easy to create Mac Applications based on node-webkit, simplifying testing and building procedures. It takes care of creating the executable, attaching the app icon and configuring the plist file accordingly.
https://micc83.github.io/nuwk-doc/
106 stars 17 forks source link

Support project-wide configuration #5

Open mackwic opened 10 years ago

mackwic commented 10 years ago

I am still uncertain about the greatest name convention for this (maybe throw it in the package.json ? But which one ?)

Anyway, we need a project-wide configuration. Defaults will be the one shipped with the application, and each value will be overridable.

Proposals for the local config file:

Sparse config file are bad. It clutters the file tree with thing we never edit again. I am all for checking first the dedicated config file, then check for the nuwk key in the package.json, then apply defaults.

What do you think of that ?

micc83 commented 10 years ago

I think it fits. About the name i guess .config.nuwk would be more obvious.

mackwic commented 10 years ago

So be it.

mackwic commented 10 years ago

node-runtime-configuration seems to handle the job quiet well, with environment and command lime overloading if necessary.

It will look at .nuwkrc files, though. Rc standing for "runtime configuration". It's ok for me, what do you think ? By the way, I am pinging the owner of the repo, just to see if he's responsive. If not, I'll fork and we can adapt the project to our needs.

micc83 commented 10 years ago

Hi @mackwic, any new from the owner?

mackwic commented 10 years ago

Yep, he’s waiting for my pull request, which is on its way. Then we’ll just have to nom install his package.

It will probably be ok wednesday.

--   Thomas Wickham thomas@wickham.epimeros.org

De: Alessandro Benoit notifications@github.com Répondre: micc83/Nuwk reply@reply.github.com Date: 7 juillet 2014 at 15:32:53 À: micc83/Nuwk nuwk@noreply.github.com Cc: Thomas Wickham thomas@wickham.epimeros.org Sujet:  Re: [Nuwk] Support project-wide configuration (#5)

Hi @mackwic, any new from the owner?

— Reply to this email directly or view it on GitHub.

micc83 commented 10 years ago

Cool!

2014-07-07 15:34 GMT+02:00 Thomas Wickham notifications@github.com:

Yep, he’s waiting for my pull request, which is on its way. Then we’ll just have to nom install his package.

It will probably be ok wednesday.

Thomas Wickham thomas@wickham.epimeros.org

De: Alessandro Benoit notifications@github.com Répondre: micc83/Nuwk reply@reply.github.com Date: 7 juillet 2014 at 15:32:53 À: micc83/Nuwk nuwk@noreply.github.com Cc: Thomas Wickham thomas@wickham.epimeros.org Sujet: Re: [Nuwk] Support project-wide configuration (#5)

Hi @mackwic, any new from the owner?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/micc83/Nuwk/issues/5#issuecomment-48178330.

Alessandro Benoit Cel: +39 392 0078370 Email: micc83@gmail.com