search

micc83 / fontIconPicker

🌈 jQuery fontIconPicker v2 is a small (3.22kb gzipped) jQuery plugin which allows you to include a simple icon picker with search and pagination inside your administration forms.
http://micc83.github.io/fontIconPicker/
MIT License
266 stars 86 forks source link

Discussion and updates for 2.0.0 #4

Closed swashata closed 10 years ago

swashata commented 10 years ago

I am working on a new documentation template (please check index-new.html), let me know what you think of it. Also I've added two new public methods (already in the docs), please do a review.

micc83 commented 10 years ago

Dude.... it's amazing! I've only made some minor changes (i think it look easier to read that way). schermata 05-2456791 alle 09 38 15

I'll keep checking for bugs...

swashata commented 10 years ago

Cool, while you are at it, may I know what text editor you are using and it's settings? Here are my configs:

  1. Sublimetext 3 (latest dev build).
  2. Indentation using tab (shows as 4 spaces).
  3. A new line at the end of file.
micc83 commented 10 years ago

Sublimetext 2 and 4 spaces indentation. What is the newline at the end of the file for?

2014-05-13 10:19 GMT+02:00 swashata notifications@github.com:

Cool, while you are at it, may I know what text editor you are using and it's settings? Here are my configs:

  1. Sublimetext 3 (latest dev build).
  2. Indentation using tab (shows as 4 spaces).
  3. A new line at the end of file.

— Reply to this email directly or view it on GitHubhttps://github.com/micc83/fontIconPicker/issues/4#issuecomment-42928842 .

Alessandro Benoit Cel: +39 392 0078370 Email: micc83@gmail.com

swashata commented 10 years ago

That is just some cross platform compatibility. I am basically using the coding standard of WordPress :smile:

micc83 commented 10 years ago

Fair enough and good to me! :)

2014-05-13 10:35 GMT+02:00 swashata notifications@github.com:

That is just some cross platform compatibility. I am basically using the coding standard of WordPress [image: :smile:]

— Reply to this email directly or view it on GitHubhttps://github.com/micc83/fontIconPicker/issues/4#issuecomment-42930099 .

Alessandro Benoit Cel: +39 392 0078370 Email: micc83@gmail.com

swashata commented 10 years ago

Cool. Also please tell me what git client are you using? I am using the one for windows and it is giving me a hard time to fetch from your update. Everytime I do git fetch it comes up with fatal: refs/remotes/origin/pr/2 tracks both refs/pull/2/head and refs/heads/pr/2. Any idea how to solve this? I am thinking about starting over with a fresh set of repository (on my local development machine).

swashata commented 10 years ago

Ah! Nevermind, figured it out on some github forums. It was because of the unnecessary pr/2 branch which got created while merging by previous pull request.

micc83 commented 10 years ago

I'm using the Mac client. It works pretty smoothly! Let me know if you get further fetching errors.

swashata commented 10 years ago

No worries, I think it happened because when I cloned this repository the pr/2 branch got a conflict with /pull/2 head. It is working fine now. Bdw, I am updating the demo. Should be able to commit within one hour or two.

micc83 commented 10 years ago

Great. Can't wait to see it done :)

2014-05-13 12:39 GMT+02:00 swashata notifications@github.com:

No worries, I think it happened because when I cloned this repository the pr/2 branch got a conflict with /pull/2 head. It is working fine now. Bdw, I am updating the demo. Should be able to commit within one hour or two.

— Reply to this email directly or view it on GitHubhttps://github.com/micc83/fontIconPicker/issues/4#issuecomment-42940094 .

Alessandro Benoit Cel: +39 392 0078370 Email: micc83@gmail.com

swashata commented 10 years ago

Hello,

I've further improved the event triggering and element positioning so that

  1. Elements are properly sized even if the parent container is hidden
  2. Change event plays nice with default browser events (on which many validation engines depend upon, like bootstrapValidator).

All examples are added, pending is to write the source code. Please review the main JS file and let me know what you think.

micc83 commented 10 years ago

I love the way you managed input events and also the margin hack to remove the gap :) Unfortunately i don't have much time to dedicate to the project at the moment. Very tight schedule this week :( Hopefully i'll be less busy next week. However, as soon as you think we're ready, i'll publish the new version on the website (i'll keep also the old one v1.0.0 for reference on a new address). I've also to implement fontIconPicker on ACF which i guess got to version 5!

2014-05-13 15:17 GMT+02:00 swashata notifications@github.com:

Hello,

I've further improved the event triggering and element positioning so that

  1. Elements are properly sized even if the parent container is hidden
  2. Change event plays nice with default browser events (on which many validation engines depend upon, like bootstrapValidator).

All examples are added, pending is to write the source code. Please review the main JS file and let me know what you think.

— Reply to this email directly or view it on GitHubhttps://github.com/micc83/fontIconPicker/issues/4#issuecomment-42952849 .

Alessandro Benoit Cel: +39 392 0078370 Email: micc83@gmail.com

swashata commented 10 years ago

Hello,

That is fine :) I will finalize everything within a few more hours. Only things left are putting source code the documentation and minify the files. Shouldn't take much time. Also shall I remove the old index.html and style.css from the branch 2.0.0?

micc83 commented 10 years ago

Of course. Rename both and delete old files! As soon as you're done i'll do a fast double and hopefully tomorrow morning we'll be online with the new version. I feel a bit guilty cause i did pretty much nothing for this release :)

2014-05-13 15:56 GMT+02:00 swashata notifications@github.com:

Hello,

That is fine :) I will finalize everything within a few more hours. Only things left are putting source code the documentation and minify the files. Shouldn't take much time. Also shall I remove the old index.html and style.css from the branch 2.0.0?

— Reply to this email directly or view it on GitHubhttps://github.com/micc83/fontIconPicker/issues/4#issuecomment-42957736 .

Alessandro Benoit Cel: +39 392 0078370 Email: micc83@gmail.com

swashata commented 10 years ago

That's great news. And please don't worry about this release! I built on top of your code and it is one of the finest ;)

swashata commented 10 years ago

Alright. I've made my final commit. Could you please test it. I have already checked for errors and bugs and fixed what I could find. Here are some stuff you can see:

  1. Check if search value is rendered properly from icon source when searchSource not provided.
  2. Check the above with the APIs (setIcons, refreshPicker etc).
  3. Check event triggering. I have modified to trigger both input (only if the browser supports) and keyup along with change for INPUT elements (for SELECT it is just change). Hopefully this will provide compatibility with most of the validators.
  4. Change the size information of the gzipped script (currently it is 1.58K, which I am sure would get increased) on both index.html and readme.md.

That only I could think of right now. I will catch you tomorrow.

micc83 commented 10 years ago

Hi @swashata really good job as usual. I started to improve the code comments in the examples. Have to assume that most people will just do a copy & paste :smile: Check ac6543b Ps. Example 8 is actually example 9 (already fixed in the next commit).

swashata commented 10 years ago

Great... Bdw, Example 8 is fontello config.json and Example 9 is icomoon selection.json and also it uses the tags in the json file for searching. So those are different :)

swashata commented 10 years ago

Oh! I see the stupid fix :D

micc83 commented 10 years ago

All right!

I guess what is missing now is to update the readme.md file (could you?)... what else?

swashata commented 10 years ago

Looks excellent. Yes I am perfectly okay with the MIT license. I think the only two things left are readme (as you mentioned) and the update the size of the gzipped file. I can do them, but might take a while since I have some work to do on one of my product now :(. It would be really great if you can handle them. Also I was thinking perhaps include a picture on the readme file for a quick preview. Let me know what you think.

swashata commented 10 years ago

PS: This is the other project I was talking about. Just released version 1 and I think you would be interested ;) https://github.com/swashata/IcoMoonIconIndexer

micc83 commented 10 years ago

Pretty cool. We shoud link it on fontIconPicker docs. Have yout thought about making a web app out of it? A webpage where you can upload your icomoon (or fontello) package to download a json file with categorized icons? Ready to use with fonticonpickers. That way you won't have to include a php script only for building icon sets. Just an idea :smile:

Ps. Sorry i'm delaying fontIconPicker release but i've got no internet at home cause i just moved and i'm pretty busy at work.

swashata commented 10 years ago

The webapp seems a pretty good idea. And no worries for the fontIconPicker release. Do you want me to update the readme.md file?

swashata commented 10 years ago

It seems no commit since I last updated so I will update the readme.md file and the size information.

micc83 commented 10 years ago

I you have time i would really appreciate it :smile: Later on you'll have to give me your skype to keep in touch.

2014-05-15 11:07 GMT+02:00 Swashata Ghosh notifications@github.com:

It seems no commit since I last updated so I will update the readme.mdfile and the size information.

— Reply to this email directly or view it on GitHubhttps://github.com/micc83/fontIconPicker/issues/4#issuecomment-43185377 .

swashata commented 10 years ago

Sure. I am updating now. I will mail you my skype :)

swashata commented 10 years ago

Done and good to go live.

micc83 commented 10 years ago

Merged and updated the webpage! :smile:

swashata commented 10 years ago

It looks great. So milestone 2.0.0 reached. I am gonna get us some beer :beers: :smile:

micc83 commented 10 years ago

I'll be glad to offer you one when you'll come to italy!! :smile: :beers: