micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
617 stars 334 forks source link

Rockets dissapearing #1195

Open Valdevon opened 10 years ago

Valdevon commented 10 years ago

Me and my friends are playing on a server, and sometimes when a rocket reaches the height it needs to get to to leave an atmosphere, the player's connection on the server will time out. Whenever this happens, the landing craft only contains 9 launch pads, and not the rocket or fuel, essentially deleting the rocket and all of its contents.

radfast commented 10 years ago
  1. Which exact version of Galacticraft?
  2. Do server and players have the exact same version?
  3. Which exact Forge version?
  4. Please post an extract from the logs on both server and clients for around 1 minute before/after this happened.
  5. Better still, enable debug mode (in config/Galacticraft/core.conf) on server and client and then post the logs. Extracts are fine, I don't need to see the whole log, only the parts at around the time when this happened.
radfast commented 10 years ago

If you're not using version 3.0.5.229, it would definitely be a good idea to test that version first (obviously server + client must both upgrade) as there have been recent changes aimed at improving rocket stability when the server/client connection is laggy.

Valdevon commented 10 years ago

WE updated this morning, and a similar problem happened, the player was disconnected as they returned home and the parachest did not spawn

  1. running version 3.0.5.229
  2. yes
  3. 10.13.2.1232

02.11 12:09:24 [Server] INFO [12:09:24] [Server thread/INFO]: samwise2435 left the game 02.11 12:09:24 [Disconnect] User [12:09:24] [Server thread/INFO]: samwise2435 has disconnected, reason: TextComponent{text='Disconnected', siblings=[], style=Style{hasParent=false, color=null, bold=null, italic=null, underlined=null, obfuscated=null, clickEvent=null, hoverEvent=null}} 02.11 12:09:03 [Server] INFO [12:09:03] [Server thread/INFO] [FML]: Unloading dimension 26 02.11 12:08:55 [Server] INFO [12:08:55] [Server thread/INFO] [Galacticraft]: Server attempting to transfer player samwise2435 to dimension 0 02.11 12:08:55 [Server] INFO [12:08:55] [Server thread/INFO] [Galacticraft]: Found matching world (0) for name: Overworld (read from bottom to top)

Just so you know, this type of problem doesn't happen every time, and seems to happen more often with people with weaker connection to the server, so it's very possible our server/internet just can't keep up :P

radfast commented 10 years ago

We want to make sure Galacticraft rockets and dimension changes work properly for players with weaker connections to the server - that seems pretty important.

There are two different issues here, first why are the disconnects happening, and second, why is the parachest information (or return rocket information) being lost on re-logging. That shouldn't happen. But we should figure out the disconnects first, because that may have something to do with it.

Please can you provide more logs. Especially, the client (samwise2435) log covering the exact same time period covered in the above log.

Please do also enable debug logging in Galacticraft - on both client and server, you can do it by editing config/Galacticraft/core.conf like this:

B:"Enable Debug Messages"=true

Also, what is Dimension26 on your server? Is it a space station, so the player is falling from space station to the Overworld?

Valdevon commented 10 years ago

Samwise2435 naturally got a bit turned off space travel after losing his rockets, so it might be a while before I am able to get logs from him, if anything else happens to other players I will post logs here. Thanks for your help.

I've enabled the debug messages and will provide them with logs if I upload any,

radfast commented 10 years ago

Any server admin can use command /dimensiontp Samwise2435 to give him a free ride to space if you need to, obviously that won't help us to test the rockets but might make the player happier.

EzerArch commented 8 years ago

The last reply is over 1 year old, and nobody else has complained ever since.

@Valdevon, or to whom it may concern, does this problem still happen?

radfast commented 8 years ago

:)

I have left this issue open to remind myself to look at possible item loss when players disconnect while using rockets ... on my to do list, I actually have a question for myself which I don't know the answer to: if - on a server - player 1 launches in a rocket while player 2 is standing on the ground watching (so that the chunk stays loaded), what happens to the rocket if player 1 disconnects mid-flight? I think the rocket will continue to fly, and player 1 might lose items because he will not be online when the rocket reaches the top of the atmosphere and goes through its sequence of placing player 1 into the Celestial Map screen + providing him with the correct items and fuel in the parachest / lander which he will have after that.

The desired outcome is that when player 1 next logs on, he is in the Celestial Map screen and will have the correct items in his parachest / lander afterwards.

The server timing out, reported in the original post, is probably the same as issue #2001, which is one of the most important issues reported to Galacticraft, and now fixed. I can't investigate that without the info requested. But the player disconnection I can test easily if I get another PC onto my LAN.

EzerArch commented 6 years ago

The last reply is over 1 year old, and nobody else has complained ever since.

Now it's 3 years old. :V

radfast commented 6 years ago

I have left this issue open to remind myself to look at possible item loss when players disconnect while using rockets ... on my to do list, I actually have a question for myself which I don't know the answer to: if - on a server - player 1 launches in a rocket while player 2 is standing on the ground watching (so that the chunk stays loaded), what happens to the rocket if player 1 disconnects mid-flight? I think the rocket will continue to fly, and player 1 might lose items