micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
617 stars 334 forks source link

Asteroids dropping my players fps down to 0.2 #2809

Closed SebaSphere closed 4 years ago

SebaSphere commented 7 years ago

I know it's not a problem with their PC because I have a great Computer And still have terrible fps Using build 105 1.11.2

radfast commented 7 years ago

That's not happening for me, on an average PC.

Can you be much more specific about how to see this:

I suggest test with different view distances.

A known issue is that the vanilla lighting engine has really bad performance in the Asteroids dimension, because it doesn't deal well with the amount of empty space (like huge caves). But this mainly affects block placement, it shouldn't affect you if you're just flying around the dimension and not building.

MrEyeballs29 commented 7 years ago

Is this a performance Issue?

radfast commented 7 years ago

It's a "cant reproduce" issue @MrEyeballs29

If you're also seeing the issue in your game, it would help us to have details of what steps we can take to see the issue.

SixtyFourWarrior commented 7 years ago

We get a huge fps drop (drops to 0-3) in asteroids in server with render distance 12. Reducing it to 2 is fine but still getting 0 fps while rendering new chunks, fps drop is not that big on singleplayer, but still exists.

radfast commented 7 years ago

thanks for the update, please give more info (for example, Sponge version) so I can test a similar setup

do you know how to run a CPU profiler on a running Java application? for example VisualVM which is part of the Java 8 JDK you can download from Oracle? (there are also Minecraft-specific tools like Opis and WarmRoast, not sure about 1.11.2 versions of those)

It would be very useful if you can run a CPU profiler on the server and show me the results. In VisualVM, I would make a "Snapshot" for around 20 seconds then take a look at what it shows.

Also check the memory, if it's heading up above 90% of available memory on the server then you might be able to fix this just by giving it some more memory.

SixtyFourWarrior commented 7 years ago

Well, I don't have access to files as I am not a staff on Seba's server so I don't know Sponge version, sorry :/ But maybe Seba will tell you I think.

SebaSphere commented 7 years ago

https://images.discordapp.net/attachments/315630594509766666/324660325074993152/2017-06-15_00.21.17.png?width=771&height=449

radfast commented 7 years ago

Thanks for the F3. 7 fps doesn't look good.

Memory looks fine.

I'm not seeing the same fps problem in my test system, which has similar PC specs. The only difference looks to be Optifine. Please try it without Optifine ...

lukacat10 commented 6 years ago

I can tell that for a long time I had severe issues with the astroid dimension (performance wise). My PCs (yes I have tested it in more than one) are not the best, but have mid grade nvidia gpus. Recently after going 0.5 fps for a while I managed to get a nice crash. I have attached the fml crash report.

I got the crash while trying to get out of the map (after failing to launch from the astroid dimension)

I will also save a copy of all the logs in case you need them. Just ask.

launcher_log.txt

TheQuadShot commented 6 years ago

It looks like the old cascading worldgen bug that has been fixed, Please update to the latest build (118). https://micdoodle8.com/mods/galacticraft/downloads

radfast commented 6 years ago

@lukacat10 sorry for time taken to respond to this, I wasn't watching this thread for some reason

I'm not sure if the "cascading worldgen bug" affected that crash at all - it was over 1 minute earlier in the log - but generally if you see a cascading worldgen message, it only creates minor lag as it only means a few extra chunks were generated. (And the game would have had to generate those chunks some time....) You don't have a "runaway" worldgen problem unless you see that message repeated over and over again.

    Exception: java.lang.OutOfMemoryError

Probably too late to be useful but it looks to me like the crash you posted is due to not enough memory for Java - you need to increase the memory you give the JVM

radfast commented 6 years ago

@SebaSphere and others reporting this: one more thought is it could be Optifine related. If possible please try the same game world with and without Optifine, and try changing different video settings (view distance, textures, particles, mipmaps etc) to see if there's one specific thing which affects it.

We really need a Java profile to resolve this properly, but I can't do that unless I can re-create the issue in my own game.

I have a gaming PC which is definitely not powerful (32 bit Windows, old 3.0GHz Athlon64 CPU, NVidia GTX 750) but it can easily maintain 50-60fps in the Asteroids dimension with Minecraft video settings all Fancy.

It's possible that there's this one specific block or mob entity which is causing all the render lag, so please also pay careful attention to whether the fps changes according to what is on-screen - easy to see if there are changes in fps if the player looks in different directions.