micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
617 stars 334 forks source link

Is there a way to create new recipes inside Gas Liquefier through Minetweaker/Modtweaker? #2867

Closed lightning02 closed 7 years ago

lightning02 commented 7 years ago

I would like to add custom gasses into liquids, making hydrogen and nitrogen to fuse and create Ammonia.(The Ammonia is made from customitems mod). But I really was hoping for the process being made through Gas Liquefier machine :l

radfast commented 7 years ago

There is no way to do this currently. To do it would need two things: (a) on Galacticraft's side we would need to make an API method for adding recipes to the Gas Liquefier (b) on Minetweaker/Modtweaker's side, they would then need to code for that API specifically

It's a good idea, but it's not worth us doing the API coding unless Minetweaker / Modtweaker will then be willing to add it as a feature - have you asked them? Happy if you want to link to this issue.

Anyhow, I am closing this as it is not an "issue" with the Galacticraft mod as currently released, it is more of a question / suggestion.

Even though this is closed, you are welcome to carry on discussing it here, and if there is a solid case for an API change then that is something we can add to the list of suggestions which we plan to implement.

Note that the Gas Liquefier only accepts one input gas, so even with custom recipes there would be no way to fuse hydrogen and nitrogen in this machine. The job of the machine is to turn gases into their corresponding liquids. By fractional distillation this can transform a mixed gas (e.g. air or "atmospheric gases") into two liquids.

Syndaryl commented 7 years ago

I understand that CraftTweaker actually has an API for you to add your own items without them doing a mod update.

lightning02 commented 7 years ago

@radfast I guess I could create an item like a tank called "Hydrogen-Nitrogen Gas Mix" and leave the pressure-fractionational process to the Gas Liquefier in order to obtain the liquid Ammonia.

lightning02 commented 7 years ago

@radfast the owner of craft tweaker said that he could help / guide you eventually if you want to add support for it

radfast commented 7 years ago

Thanks @lightning02 that could be great, who is the owner of CraftTweaker?

Syndaryl commented 7 years ago

@jaredlll08 is the project lead/maintainer/whatever over at CraftTweaker. Active developer.

jaredlll08 commented 7 years ago

o/ You could say I'm active most of the time anyway, I'm only really support 1.12 at the moment, baring 1 or 2 PR's for 1.11 final release, so if GC is 1.12, I'm happy to add support for it in Modtweaker, if not, maybe work on adding support in GC directly?

radfast commented 7 years ago

thanks @jaredlll08

we are currently in bugfix phase for 1.10 and 1.11, so not yet in 1.12.

in principle I'm happy to support CraftTweaker for our various machines which have specific recipes. Please can you link me to an example of another mod implementing the API?