search

micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
616 stars 334 forks source link

Moon buggy view + Vivecraft #3100

Open lolmetimbers opened 6 years ago

lolmetimbers commented 6 years ago

Galacticraft 4 on 1.10.2

I am experiencing a very odd problem where if I enter a moon buggy with Vivecraft, the view height is switched to be underneath the buggy and inside the ground.

This is obviously game and immersion breaking, so is there a way to change/edit the view distance so that it is higher (above ground)?

radfast commented 6 years ago

The player height when riding a moon buggy is hard-coded.

How does Vivecraft deal with players riding minecarts, horses, pigs etc?

Some screenshots could be helpful. Also, have you reported this to Vivecraft devs? It's not too likely that the problem is on our side.

Also just to check: with Vivecraft you should be using this config option in Galacticraft core: B:"Disable Vehicle Third-Person and Zoom"=true

lolmetimbers commented 6 years ago

I have just contacted them and hope to resolve the compatibility conflict.

B:"Disable Vehicle Third-Person and Zoom"=true. Am on Galacticraft-1.10.2-4.0.0.119

Unfortunately, this does not do anything and my view still changes to under the buggy.

If anything, can you point me to the code value that i need to edit to raise the y axis height? Many thanks Is this the file? https://github.com/micdoodle8/Galacticraft/blob/master/src/main/java/micdoodle8/mods/galacticraft/core/items/ItemBuggy.java

radfast commented 6 years ago

The code you want is here

It's probably the -3.0 offset there which is causing this - but this is needed for the buggy-mounted player height to be correct without Vivecraft.

If you can figure out a good number there with Vivecraft present (are you able to compile and build Galacticraft 1.10?) then we can hard-code the Vivecraft number and join it to that B:"Disable Vehicle Third-Person and Zoom"=true config setting.

(If you are not able to compile and build GC1.10 for yourself, I can make a custom-build for you for testing, and upload it somewhere.)

Unfortunately I am not able to test Vivecraft on my PC because I don't have the hardware, and the mod crashes when I try to run it, not sure why.

lolmetimbers commented 6 years ago

I should be able to compile and find a good value for the y height. Thank you for pointing me to the right value. Will report back within the next few days!