micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
617 stars 334 forks source link

Solar Panels continue generate energy when it's raining on Venus #3338

Open FrostQ opened 6 years ago

FrostQ commented 6 years ago

Minecraft version: 1.12.2 Galacticraft version: 4.0.1.194

Single player (SSP), Multiplayer (SMP), or SSP opened to LAN (LAN)? Yes

Galacticraft add-ons and other mods installed? Yes

Please provide screenshots / crash report / log as needed.

Solar Panels produce energy on Venus during rain Should sun not visible on sky during rain? Both basic and advanced is flip over (visible on below screen) 2018-04-10_22 10 32 2018-04-10_22 30 02


On Overworld have 11 day but on Venus (or other GC dim) have day 5 (instead 11) Why? Solar panel produce energy on Mars during night (look clock) 2018-04-10_22 14 54

TheQuadShot commented 6 years ago

Solar panels work in the rain cause they work on light frequency just below infrared (not visible to human eye).

radfast commented 6 years ago

Our Galacticraft Solar Panels are intended to stop working in the rain, because they switch to that upside-down configuration. (Guess we didn't do enough research into current real solar technologies, sorry @TheQuadShot!)

It follows that it is intended that there is a significant reduction in average electricity generation on Venus now that acid rain is a frequent occurrence. See also #3270.

Thanks for reporting the issue, seems like there must be a bug here. Most likely it's connected with what "raining" means on Venus ... Venus acid rain is not "rain" for most game purposes, for example acid rain will not hydrate farmland.

Thanks also for reporting Mars at night time. I'll check both.


Time: did you use a Cryogenic Chamber on any of these planets? Intended behaviour is that the Cryogenic Chamber advances the daycount only on the planet where it is used. Because of this, planets can easily get out of sync with their clocks.

This is intended, because the alternative is that somebody using a Cryogenic Chamber on Mars (for example) would also cause clocks on the Overworld to advance to next morning. And that just seems wrong. Even more so when you think about Moon and Venus which have day lengths much longer than the Overworld day.

This will also allow us, in future, to give Mars a day length of ~25 hours instead of 24 hours, so that it will also go out of sync with the Overworld for that reason. We just didn't get around to coding that yet...

TheQuadShot commented 6 years ago

Sorry, ;-) I agree in this instance they absolutely should flip over! I don't want to have to replace them every 3rd or 4th storm. but on the overworld.....