search

micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
615 stars 333 forks source link

[1.12.2] Shield Controller conflict with Silent Gem's Armor XP. #3946

Open SonicX8000 opened 4 years ago

SonicX8000 commented 4 years ago

Opening up an issue here, should've did this awhile ago.

Refer'd Issue: https://github.com/SilentChaos512/SilentGems/issues/412

Minecraft: 1.12.2 Forge: 14.23.5.2847

Mods: 6 GalacticraftCore-1.12.2-4.0.2.254 Galacticraft-Planets-1.12.2-4.0.2.254 jei_1.12.2-4.15.0.291 MicdoodleCore-1.12.2-4.0.2.254 SilentLib-1.12.2-3.0.13+167 SilentsGems-1.12.2-2.8.22+327

=====

Silent Gems adds in gems, armor & tools along other stuff and there's a 'leveling up' mechanic where your weapons & tools level up when you craft a tool soul into them.

If wearing Gem Armor from Silent Gem's that is crafted with a tool soul & you have the Shield Controller from Galacticraft equipped... the Gem Armor won't gain any XP when you take damage that affects armor such as mob, arrow, cactus, anything that affects the armor's durability. It will not grant XP if the damage source ignores armor such as magic, fall, etc.

Gem Armor will gain XP if it somehow has the 'Unbreakable' tag.

I don't know if any other items out there make use of the armor losing durability to gain XP or some other stuff, but still figure I give it a mention.

micdoodle8 commented 4 years ago

I might be misunderstanding, but the XP gain from Silent Gems is a tradeoff for the item taking damage right? So I think having armour be indestructible from our shield controller while also gaining soul XP would be a bit overpowered, no?

SonicX8000 commented 4 years ago

Semi Vanilla-wise, maybe. In a private survival world I have a mod added that upscales damage taken and at a certain point, armor breaks too quickly. The Shield Controller is nice to have to ensure that your armor doesn't shatter within a few hits.