micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
617 stars 332 forks source link

[1.7+] API Bug: Custom Oxygen Tanks are not considered in GC Player Rendering of Oxygen Tanks #4019

Open MJRLegends opened 4 years ago

MJRLegends commented 4 years ago

1.8+ : https://github.com/micdoodle8/Galacticraft/blob/MC1.8/src/main/java/micdoodle8/mods/galacticraft/core/client/render/entities/layer/LayerOxygenTanks.java#L68-L73

1.7.10: https://github.com/micdoodle8/Galacticraft/blob/MC1.7/src/main/java/micdoodle8/mods/galacticraft/core/entities/player/GCPlayerHandler.java#L244-L282

Would be amazing if you could fix in everything all the way back to 1.7.10 since this is a api bug so affect other mods...

From my testing i just got nothing rendering but in bug report https://github.com/MJRLegends/ExtraPlanets/issues/549 they have some how got a missing texture to render? could be other addons doing stuff here??