micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
617 stars 332 forks source link

Galacticraft + HWYLA bug #4049

Closed davo899 closed 4 years ago

davo899 commented 4 years ago

REVIEW THE GUIDELINES - see Contributing link on right side.

Minecraft version: 1.12.2 Galacticraft version ("latest" is not a valid option): 4.0.2.280

Single player (SP), Multiplayer (MP), or SP opened to LAN (LAN)?

Any Galacticraft add-ons installed? Please list all of them: Planets, Tweaker

Please upload crash report / full log to Github Gist or any other paste site: https://gist.github.com/davo899/950e742383cec0bb4fbc78ae423123c7 Probably not useful, server shut down automatically because it froze for 60 seconds.

Please provide screenshots / videos / full modlist as needed: Modlist: https://www.curseforge.com/minecraft/modpacks/project-ozone-3-a-new-way-forward

Please state the site that you downloaded Galacticraft from: Twitch? (Came with Project Ozone 3)

The main issue is this error: [net.minecraft.server.MinecraftServer]: Error executing task java.util.concurrent.ExecutionException: java.lang.NullPointerException at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_242] at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_242] at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?] at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:723) [MinecraftServer.class:?] at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397) [nz.class:?] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242] Caused by: java.lang.NullPointerException at micdoodle8.mods.galacticraft.api.vector.BlockVec3.getTileEntityOnSide(BlockVec3.java:439) ~[BlockVec3.class:?] at micdoodle8.mods.galacticraft.core.energy.tile.TileBaseUniversalConductor.getCapability(TileBaseUniversalConductor.java:457) ~[TileBaseUniversalConductor.class:?] at mcp.mobius.waila.addons.capability.HUDHandlerEnergy.getNBTData(HUDHandlerEnergy.java:46) ~[HUDHandlerEnergy.class:?] at mcp.mobius.waila.network.MessageRequestTile$Handler.lambda$onMessage$0(MessageRequestTile.java:93) ~[MessageRequestTile$Handler.class:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_242] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_242] at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?] ... 5 more

I followed the stack trace and found the issue starts in HWYLA>mcp>mobius>waila>addons>capability>HUDHandlerEnergy.java In getNBTData, it calls getCapability on an instance of TileBaseUniversalConductor (TileEntity player is looking at, in my case Sealed Aluminum Wire) and passes in a null EnumFacing object as the second parameter. In getCapability, getTileEntityOnSide is called on a new BlockVec3 object and the EnumFacing object is passed in again. In getTileEntityOnSide, ordinal() is called on the EnumFacing object, causing a NullPointerException. This happens on every tick the player is looking at the block, causing the server to hang and crash.

Edit: I found that this only happens while EnderIO is installed, since if it isn't installed, getCapability just returns immediately.

(I did see contributing rule #5 but the HWYLA page doesn't allow issue posts)

davo899 commented 4 years ago

Sorry, posted before seeing all these duplicates: https://github.com/micdoodle8/Galacticraft/issues/4035 https://github.com/micdoodle8/Galacticraft/issues/4043 https://github.com/micdoodle8/Galacticraft/issues/4020

MJRLegends commented 4 years ago

Probably best to just close this issue reports as we already got the 3 open so no need for this one