search

micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
617 stars 332 forks source link

[Sponge] Fix dungeon generation on the moon #4053

Closed marcus8448 closed 3 years ago

marcus8448 commented 4 years ago

Fixes #3789

It's definitely not the nicest way to do it, so it only changes logic if sponge is loaded.

clienthax commented 4 years ago

Fixes #3789

It's definitely not the nicest way to do it, so it only changes logic if sponge is loaded.

What is the actual issue here on the sponge side?

MJRLegends commented 4 years ago

Probably sponge mixin overriding stucture methods causing something to get conditioned out for working

MJRLegends commented 4 years ago

But hard to tell since so many commits making it confusing to see changed at once

micdoodle8 commented 3 years ago

Yikes, unfortunate that this is necessary, but thank you for the fix. Merging now. This would also affect Mars & Venus dungeons, right?