micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
617 stars 332 forks source link

[1.12.2] Crash if question mark present in space station name #4070

Open chordtoll opened 3 years ago

chordtoll commented 3 years ago

REVIEW THE GUIDELINES: ✓

Minecraft version: 1.12.2 Galacticraft version ("latest" is not a valid option): 4.0.2.280

Single player (SP), Multiplayer (MP), or SP opened to LAN (LAN)? : MP If MP server, please mention if it has Sponge, AtomMC, BukkitForge, BungeeCord etc.: None of the above. Plain forge server.

Any Galacticraft add-ons installed? Please list all of them:

Please upload crash report / full log to Github Gist or any other paste site: https://gist.github.com/chordtoll/eb42a330d1ceb9cf55cb85e3462c9eb4

Please provide screenshots / videos / full modlist as needed I don't believe any are needed, though can provide more info if it turns out to be relevant

Please state the site that you downloaded Galacticraft from: https://micdoodle8.com/mods/galacticraft/downloads

Description of issue:

I renamed a space station, and the new name contained a question mark. Now, any time the planet selection screen would be displayed, the game crashes with a java.lang.ArrayIndexOutOfBoundsException: 4.

Manually NBTEditing the world/galacticraft/spacestation_x.dat file and removing the question mark prevents the crash.