search

micdoodle8 / Galacticraft

An advanced Space Dimension Mod for Minecraft
Other
610 stars 329 forks source link

Rocket engine sound continues after rocket runs out of fuel #431

Closed L-Clouds closed 10 years ago

L-Clouds commented 10 years ago

Title pretty much explains it. The rocket engine sound does not cease when the rocket runs out of fuel and its flame extinguishes.

Tested with the "Creative pre-fueled Tier 1" rocket in pure Galacticraft 1.6.4-2.0.13.1067. Haven't tested other kinds of rockets.

radfast commented 10 years ago

Thank you very much for spotting this. It should be fixed in the next build for all types of rockets.

Out of interest, how many blocks did the Tier 1 rocket travel before it ran out of fuel?

L-Clouds commented 10 years ago

Oh, well, I didn't measure that. Actually, I just flew in circles until out, since I was testing just how big is the blast from a crashing rocket, after seeing the recent Yogscast video where they just about nuked their skyscraper with one. (Conclusion: something else explosive must have been present.)

Tested on the moon, flame-out happens after about 3050ish blocks of horizontal travel.

However, this bug has not been fixed. After stopping for about a second, the rocket sound resumes playing until it explodes, at least not while on the moon, in creative mode, with 1070.

radfast commented 10 years ago

So the sound stops when it should, but starts again? I'll reopen the issue in that case, until I find a complete fix.

radfast commented 10 years ago

Fixed properly in build 1071.

I've also noticed that the effect where the rocket sound gradually gets quieter as it rises into space above y=250, still happens if you fly horizontally. I'm still looking at what we can do about that.

UPDATE: We are going to have to live with that 'getting quieter above y=250 even if the rocket flies horizontally' thing for now: there is no easy fix. It can be looked at again in 1.7 when time allows - which probably won't be any time soon, there are other priorities.

Closing this now.

EzerArch commented 10 years ago

I'd like to add something, probably this bug has to do with another:

If you land your rocket on a launch pad equipped with a launch controller (which is required for you to land your rocket) the sound doesn't cut off, you have to reload the world.

Video: http://youtu.be/Ut1HvGraT7M?t=1m40s (the video is old, but the bug happened again in the last livestream with me and micdoodle8).

radfast commented 10 years ago

Hey EzerArch. I think that sound should now cut off correctly after landing, in build 1071.

(That was actually the difference between build 1070 and 1071: in 1070, the "stop the sound" code which was already present for landed ships and I just copied for a ship running out of fuel, turns out it didn't actually stop anything.)

Please re-open this issue if either of you is hearing the rocket sound after it is supposed to be stopped.

L-Clouds commented 10 years ago

Sound end at fuel-out indeed seems fixed, now. :)