search

micdoodle8 / MicdoodleCore

Includes ASM class transformers and core classes for my Minecraft mods.
Other
15 stars 18 forks source link

Allow users to see Mod Metadata in gui #12

Closed marcus8448 closed 6 years ago

marcus8448 commented 6 years ago

This sort-of helps with #5. Now forge does show the Mod metadata, but still needs a version string to actually work.

radfast commented 6 years ago

Thanks, this kind of fix is much appreciated.

I'll try to understand what you mean about a version string - making this display correctly in Forge has not exactly been one of my top priorities so far, but with your help we should try to get this right.

marcus8448 commented 6 years ago

I'll try to understand what you mean about a version string

Like: meta.version = ""

but still needs a version string to actually work.

I meant it will need a version string to have the update checker mod to not complain about micdoodlecore (Note: Needs further testing Never mind, doesn't have a problem w/o version string)

Proof that it works (Don't mind "There was an error updating this mod" message it's a bug with the update checker mod: 2018-04-25_18 37 48

PS: Shouldn't the updateUrl and url be https:// not http:// ?

Random off topic question: What is the gettingstarted.xml file for (in micdoodle8/Galacticraft (assets/galacticraftcore/manuals))? Just wondering.

radfast commented 6 years ago

Thanks again, all looks good.

radfast commented 6 years ago

gettingstarted.xml is unused. It's been around for 4 years+, probably originally in the 1.6.4 version. micdoodle8 was thinking about making an in-game tutorial in a book similar to Tinker's Construct books.

Things have moved on since then, we have NEI and JEI and Shift-descriptions on some blocks and machines, as well as a comprehensive Wiki.