micdoodle8 / MicdoodleCore

Includes ASM class transformers and core classes for my Minecraft mods.
Other
15 stars 18 forks source link

Incompatibility with Random Things Rainshield #13

Closed lumien231 closed 6 years ago

lumien231 commented 6 years ago

In your Class Transformer you seem to completely replace the Rain Particle Logic here, would it be possible for you to let the vanilla code run when you don't have to change anything about the rain? I also change that method so my code isn't run with Galacticraft installed.

radfast commented 6 years ago

Hey, thanks for looking in.

Yes, I will change it this weekend. This part of our Class Transformer is a recent addition, and I did not think enough about compatibility with other mods.

I propose to change it as described here - that will allow the vanilla code to run except on our planets.

radfast commented 6 years ago

Fixed in code. This fix will be included in our next published build 176, in the next couple of days.

radfast commented 6 years ago

Our build 176 is now available for players to download.

Should be working OK with Random Things, any more problems please let me know.